Editor doesn't work when using git on Windows

[jameshartig]

The editor doesn't work on Windows since the default GIT_EDITOR is "vi" but the way that go uses FindPath means that it's actually going to look for "vi.exe" in $PATH which doesn't exist because vi is just a bash script:

exec /share/vim/vim74/vim "$@"

To fix this you need to instead set your GIT_EDITOR environment to:

"C:\Program Files (x86)\Git\share\vim\vim74\vim.exe"

I haven't ran into this issue until I started using gh though, git handles the editor being a bash file fine. I'm not really sure how this can be fixed in go though.