From 6f45e4839a8639208804aca967d55196c5c847d6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Thomas=20M=C3=BCller?= <1005065+DeepDiver1975@users.noreply.github.com> Date: Mon, 2 Sep 2024 16:36:37 +0200 Subject: [PATCH] fix: hint user in share dialog about password policy (#41314) --- apps/files_sharing/css/sharetabview.css | 1 - changelog/unreleased/41314 | 6 ++++++ core/js/sharedialoglinkshareview.js | 2 +- core/js/tests/specs/sharedialoglinkshareviewSpec.js | 2 +- 4 files changed, 8 insertions(+), 3 deletions(-) create mode 100644 changelog/unreleased/41314 diff --git a/apps/files_sharing/css/sharetabview.css b/apps/files_sharing/css/sharetabview.css index 654f80e51626..95a46dfdf687 100644 --- a/apps/files_sharing/css/sharetabview.css +++ b/apps/files_sharing/css/sharetabview.css @@ -349,7 +349,6 @@ .public-link-modal--input[type="password"], .public-link-modal--input.datepicker { - max-width: 50%; min-width: 175px; } diff --git a/changelog/unreleased/41314 b/changelog/unreleased/41314 new file mode 100644 index 000000000000..6f863bb4b761 --- /dev/null +++ b/changelog/unreleased/41314 @@ -0,0 +1,6 @@ +Change: Add user hint in share dialog that password policy can apply + +To avoid user confusion the share dialog informs the user that password policy +can apply in case enabled. + +https://github.com/owncloud/core/pull/41314 \ No newline at end of file diff --git a/core/js/sharedialoglinkshareview.js b/core/js/sharedialoglinkshareview.js index c895f049a774..9365345ac75f 100644 --- a/core/js/sharedialoglinkshareview.js +++ b/core/js/sharedialoglinkshareview.js @@ -14,7 +14,7 @@ } var PASSWORD_PLACEHOLDER_STARS = '**********'; - var PASSWORD_PLACEHOLDER_MESSAGE = t('core', 'Choose a password'); + var PASSWORD_PLACEHOLDER_MESSAGE = t('core', 'Choose a password - password policy may apply'); var TEMPLATE = '' + '
'+ diff --git a/core/js/tests/specs/sharedialoglinkshareviewSpec.js b/core/js/tests/specs/sharedialoglinkshareviewSpec.js index 3d304e0225c6..876c2b459107 100644 --- a/core/js/tests/specs/sharedialoglinkshareviewSpec.js +++ b/core/js/tests/specs/sharedialoglinkshareviewSpec.js @@ -28,7 +28,7 @@ describe('OC.Share.ShareDialogLinkShareView', function() { var view; var PASSWORD_PLACEHOLDER_STARS = '**********'; - var PASSWORD_PLACEHOLDER_MESSAGE = 'Choose a password'; + var PASSWORD_PLACEHOLDER_MESSAGE = 'Choose a password - password policy may apply'; beforeEach(function() { configModel = new OC.Share.ShareConfigModel();