From 04bc650d13988dae6bd5966e0bc04042bac09a46 Mon Sep 17 00:00:00 2001
From: Ralf Haferkamp <rhaferkamp@owncloud.com>
Date: Thu, 17 Oct 2024 15:58:31 +0200
Subject: [PATCH] ci: drop go generate from ci pipeline

All the files generated by the ci-go-generate target should already be
tracked in git. So there is not need to run it (multiple times) in the ci.
---
 .drone.star | 28 ++++------------------------
 1 file changed, 4 insertions(+), 24 deletions(-)

diff --git a/.drone.star b/.drone.star
index 102c53b7c57..e52b4da8dbd 100644
--- a/.drone.star
+++ b/.drone.star
@@ -520,7 +520,7 @@ def restoreGoBinCache():
     ]
 
 def testOcis(ctx):
-    steps = skipIfUnchanged(ctx, "unit-tests") + restoreGoBinCache() + makeGoGenerate("") + [
+    steps = skipIfUnchanged(ctx, "unit-tests") + restoreGoBinCache() + [
         {
             "name": "golangci-lint",
             "image": OC_CI_GOLANG,
@@ -584,7 +584,7 @@ def testOcis(ctx):
     }
 
 def scanOcis(ctx):
-    steps = skipIfUnchanged(ctx, "unit-tests") + restoreGoBinCache() + makeGoGenerate("") + [
+    steps = skipIfUnchanged(ctx, "unit-tests") + restoreGoBinCache() + [
         {
             "name": "govulncheck",
             "image": OC_CI_GOLANG,
@@ -626,7 +626,6 @@ def buildOcisBinaryForTesting(ctx):
         },
         "steps": skipIfUnchanged(ctx, "acceptance-tests") +
                  makeNodeGenerate("") +
-                 makeGoGenerate("") +
                  build() +
                  rebuildBuildArtifactCache(ctx, "ocis-binary-amd64", "ocis/bin"),
         "trigger": {
@@ -1399,8 +1398,7 @@ def dockerRelease(ctx, arch, repo, build_type):
             "arch": arch,
         },
         "steps": skipIfUnchanged(ctx, "build-docker") +
-                 makeNodeGenerate("") +
-                 makeGoGenerate("") + [
+                 makeNodeGenerate("") + [
             {
                 "name": "build",
                 "image": OC_CI_GOLANG,
@@ -1544,8 +1542,7 @@ def binaryRelease(ctx, arch, build_type, target, depends_on = []):
             "arch": "amd64",
         },
         "steps": skipIfUnchanged(ctx, "build-binary") +
-                 makeNodeGenerate("") +
-                 makeGoGenerate("") + [
+                 makeNodeGenerate("") + [
             {
                 "name": "build",
                 "image": OC_CI_GOLANG,
@@ -2020,23 +2017,6 @@ def makeNodeGenerate(module):
         },
     ]
 
-def makeGoGenerate(module):
-    if module == "":
-        make = "make"
-    else:
-        make = "make -C %s" % (module)
-    return [
-        {
-            "name": "generate go",
-            "image": OC_CI_GOLANG,
-            "commands": [
-                "retry -t 3 '%s ci-go-generate'" % (make),
-            ],
-            "environment": DRONE_HTTP_PROXY_ENV,
-            "volumes": [stepVolumeGo],
-        },
-    ]
-
 def notify(ctx):
     status = ["failure"]
     channel = config["rocketchat"]["channel"]