Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade from 13.10.1.3 to 13.10.2 fails on Ubuntu. #726

Closed
sfadschm opened this issue Nov 10, 2023 · 7 comments
Closed

Upgrade from 13.10.1.3 to 13.10.2 fails on Ubuntu. #726

sfadschm opened this issue Nov 10, 2023 · 7 comments

Comments

@sfadschm
Copy link

sfadschm commented Nov 10, 2023

Steps to reproduce

  1. Run update via /.../updater/application.php

  2. Error: upgrade:backupDBlb command is not implemented

  3. Updater exits.

  4. Run update via webUI admin panel.

  5. Update is successfull, but aborts with error: upgrade:restartWebServer command is not implemented.

  6. UI is stuck and upgrade appears to not be finished.

  7. Actually, update was successful.

Expected behaviour
The upgrade runs smoothly...

Actual behaviour
The upgrade fails at the first step or is successfull but shows an error.

Server configuration
Operating system: Ubuntu 20.04.6 LTS

Web server: Apache

Database: MariaDB

PHP version: 7.4

ownCloud version: 10.13.1.3

Updated from an older ownCloud or fresh install: Updated.

@sfadschm sfadschm changed the title Upgrade from 13.10.1 to 13.10.2 fails on Debian Upgrade from 13.10.1.3 to 13.10.2 fails on Ubuntu. Nov 10, 2023
@sfadschm
Copy link
Author

Moved from owncloud/core#41057 (comment).

@sfadschm
Copy link
Author

This issue still persists with Core 10.13.3.4.

@sfadschm
Copy link
Author

sfadschm commented Dec 21, 2023

The reason is most likely this change in #711:

https://github.com/owncloud/updater/blob/master/src%2FCommand%2FBackupDbCommand.php#L46

The method now returns 1 and stops the update. Before, it returned nothing.

Same for the "restartwebserver" command.

Ref.: #713

@sfadschm
Copy link
Author

sfadschm commented Dec 21, 2023

@phil-davis Maybe the methods should return 0, i.e., fail silently? At least this seems to be how it was handled before #711. For now, we have the output that the methods are not implemented, which is quite good to know for anyone using the updater.

@phil-davis
Copy link
Contributor

PR #730 puts the behavior back, so that things that are not-yet-implemented will return command line status 0 (success), and not fail the upgrade. That should fix the problem.

It won't end up in a release until the next core release (some time in 2024, I suppose). Existing installations would need to apply that change "manually" if they want to use the updater.

@sfadschm
Copy link
Author

Thanks!
As initially stated, the updater is actually still working when running from the webUI. There it only fails at the restartWebserver command, after the actual update is already finished. So for users who use this way, it should work to just update and ignore that error.

Running the updater from the command line will however not be possible as you described.
not sure if that might be worth an update note?

@sfadschm
Copy link
Author

sfadschm commented Aug 9, 2024

Fixed in core 10.15.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants