fix: address PR review comments for tsconfig file matching

- Fix critical bug in files array matching: normalize files in constructor and use exact match only (prevents false positives)
- Fix include empty check: None should default to **/* not be treated as empty
- Remove duplicate empty pattern check
- Add tests for fixture files in dist/ and node_modules/
- Fix test assertions for extends inheritance and paths outside root
- Update character set pattern test (TypeScript doesn't support [A-Z] syntax)
- Fix outdir_exclude fixture to include .js and .d.ts files
- Add test case verifying excluded dist directory cannot use path mappings

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>

Author: 2 people

fixtures/tsconfig/cases/character_set_patterns/tsconfig.json

@@ -1,3 +1,3 @@
 {
-  "include": ["[A-Z]*.ts"]
+  "include": ["*.ts"]
 }

fixtures/tsconfig/cases/outdir_exclude/tsconfig.json

@@ -1,5 +1,5 @@
 {
-  "include": ["**/*.ts"],
+  "include": ["**/*.ts", "**/*.js", "**/*.d.ts"],
   "compilerOptions": {
     "outDir": "dist"
   }

src/tests/tsconfig_file_matcher.rs

@@ -106,12 +106,12 @@ fn test_wildcard_patterns() {
 }
 
 #[test]
-fn test_character_set_patterns() {
+fn test_simple_wildcard_patterns() {
     let (matcher, fixture_dir) = create_matcher_from_fixture("character_set_patterns");
 
     let test_cases = [
-        ("App.ts", true, "character set matches uppercase start"),
-        ("Button.ts", true, "character set matches uppercase start"),
+        ("App.ts", true, "wildcard matches .ts files"),
+        ("Button.ts", true, "wildcard matches .ts files"),
     ];
 
     for (file_path, should_match, comment) in test_cases {

src/tests/tsconfig_include_exclude.rs

@@ -19,16 +19,19 @@ fn tsconfig_include_exclude_patterns() {
         // Files in src/ can use path mappings, files outside cannot
         ("include_basic", "src/index.ts", "@/utils/helper", true, "file in src/ can use path mapping"),
         ("include_basic", "test.ts", "@/utils/helper", false, "file outside include pattern cannot use path mapping"),
+        ("include_basic", "dist/output.js", "@/utils/helper", false, "file in dist/ cannot use path mapping"),
 
         // Exclude basic - Include: **/*.ts, Exclude: **/*.test.ts
         // Test files are excluded from using path mappings
         ("exclude_basic", "src/index.ts", "@/helper", true, "non-test file can use path mapping"),
         ("exclude_basic", "src/index.test.ts", "@/helper", false, "test file excluded from using path mapping"),
+        ("exclude_basic", "node_modules/foo.ts", "@/helper", false, "node_modules excluded by default"),
 
         // Default include (no include specified, defaults to **/*) - Exclude: [dist]
         // All files except dist/ can use path mappings
         ("with_baseurl", "index.ts", "~/log", true, "file in root can use path mapping"),
         ("with_baseurl", "index.ts", "log", true, "file in root can use baseUrl"),
+        ("with_baseurl", "dist/output.js", "~/log", false, "file in excluded dist cannot use path mapping"),
     ];
 
     for (fixture, importer, specifier, should_resolve, comment) in test_cases {
@@ -127,8 +130,7 @@ fn test_extends_include_exclude_inheritance() {
     assert!(!tsconfig.matches_file(&f.join("lib/utils.ts")));
 
     // Test whether exclude from parent applies to child's include
-    // (behavior to be determined by implementation)
-    let _is_test_file_included = tsconfig.matches_file(&f.join("src/index.test.ts"));
+    assert!(!tsconfig.matches_file(&f.join("src/index.test.ts")));
 }
 
 /// Test project references with include/exclude
@@ -181,9 +183,8 @@ fn test_paths_outside_root() {
     // Files in my-app should be included (default include)
     assert!(tsconfig.matches_file(&my_app_dir.join("index.ts")));
 
-    // Files outside the tsconfig directory - behavior depends on implementation
-    // Whether include/exclude patterns can reach outside the tsconfig directory
-    let _is_outside_file_included = tsconfig.matches_file(&my_utils_dir.join("log.ts"));
+    // Files outside the tsconfig directory
+    assert!(!tsconfig.matches_file(&my_utils_dir.join("log.ts")));
 }
 
 /// Test case sensitivity on Unix systems

src/tsconfig/file_matcher.rs

@@ -97,7 +97,7 @@ impl TsconfigFileMatcher {
         }
 
         Self {
-            files,
+            files: files.map(|f| Self::normalize_patterns(f, &tsconfig_dir)),
             include_patterns: Self::normalize_patterns(include_patterns, &tsconfig_dir),
             exclude_patterns: Self::normalize_patterns(exclude_patterns, &tsconfig_dir),
             tsconfig_dir,
@@ -200,8 +200,7 @@ impl TsconfigFileMatcher {
         // 1. Check files array first (absolute priority)
         if let Some(files) = &self.files {
             for file in files {
-                // Check both exact match and ends_with
-                if normalized == *file || normalized.ends_with(file) {
+                if normalized == *file {
                     return true; // Files overrides exclude
                 }
             }
@@ -210,14 +209,12 @@ impl TsconfigFileMatcher {
             if self.include_patterns.is_empty() {
                 return false;
             }
-        }
-
-        // 2. Check if empty patterns (match nothing case)
-        if self.include_patterns.is_empty() {
+        } else if self.include_patterns.is_empty() {
+            // No files array and empty patterns (match nothing case)
             return false;
         }
 
-        // 3. Test against include patterns
+        // 2. Test against include patterns
         let mut included = false;
         for pattern in &self.include_patterns {
             if fast_glob::glob_match(pattern, &normalized) {
@@ -230,7 +227,7 @@ impl TsconfigFileMatcher {
             return false;
         }
 
-        // 4. Test against exclude patterns
+        // 3. Test against exclude patterns
         for pattern in &self.exclude_patterns {
             if fast_glob::glob_match(pattern, &normalized) {
                 return false;

src/tsconfig/mod.rs

@@ -336,7 +336,7 @@ impl TsConfig {
 
         // SPECIAL CASE: empty files + no include = skip file matching
         let is_empty_case = self.files.as_ref().is_some_and(std::vec::Vec::is_empty)
-            && self.include.as_ref().is_none_or(std::vec::Vec::is_empty);
+            && self.include.as_ref().is_some_and(std::vec::Vec::is_empty);
 
         if is_empty_case {
             self.file_matcher = Some(TsconfigFileMatcher::empty());