vite-plus/lsp: config search behind env flag

[Sysix]

Problem found in #21481, should fail on main too.

The oxfmt or oxlint LSP server only checks for vite.config.ts files, if the VP_VERSION is set.
This can create a problem, when we support files outside the current workspace.

Example

This example shows how the vite config will not be respected, when linting from a non vite project.

Setup

Project A: /home/project-a/

Has vite-plus installed and a vite.config.ts file in the root.

Project B: /home/project-b/

Uses oxfmt native without the VP_VERSION env.

Steps

• Open project B in your editor, like code /home/project-b/
• Drag a file from Project A into your editor
• Format the dragged file

Problem

Because we started the server from /home/project-b/node_modules/.bin/oxfmt, we do not set the VP_VERSION environment for the language server.
The editor will format the file with default oxfmt settings and does not search the vite.config.ts file in /home/project-a/.

[leaysgur]

Thanks for working on. I understand the problem, but honestly I'm not sure how to address it. 😓

To properly load vite.config.ts, we need to use the resolveConfig() function from vite-plus itself. This means a non-VP workspace fundamentally cannot format/lint files that belong to a VP workspace. (module vite-plus not found)

So the only alternative would be to remove the VP_VERSION gate entirely and bundle vite-plus into our apps. But, should we...? Also it will start to load every vite.config.ts in non-VP project while root config lookup and nested discovery.

NOTE: This same limitation also applies to the CLI.
While .. in paths is disallowed, absolute paths are accepted and config discovery walks up from the file's location, but it still can't cross the VP_VERSION gate.

[Sysix]

I do not know the perfect solution too. Just wanted to share my thoughts.
voidzero-dev/vite-plus#1614 Is in RFC, it is better to continue the discussion there