-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New option: Dim edges not directly connected to a clicked node #48
Comments
Thank you for creating a specific issue. It is important in my instance because it will be easier to understand the connections from and to the active node without the links between the 'non-active' nodes. I tried 2 things :
I was unable to get something working in both possibilities. I would like to know which approach is the best? |
@Princen wrote:
@Princen I'm not sure what you mean by 'direct' and 'indirect' edges. The code at that point is looping over all edges and building up sigInst.neighbors, which is a list of all the nodes that have an edge with the activeNode (a). That line could be rewritten more verbosely (but probably clearer) as:
The change I think you want (dimming edges not connected to the active node) is more involved. At the moment, all edges are hidden with the line at the interEdges function/loop you are looking at. Then, all nodes are hidden after that. Using the list of nodes sigInst.neighbors, all nodes and edges connected to them are shown later. Changing this requires a bit of a rewrite. A list of the edges will need to be kept in addition to the notes and used to determine the dim/not dim status when the edges are redisplayed. The code that undoes this when a node is deselected will also have to be rewritten I suspect. I don't have time to write this at the moment but should hopefully be able to look at in later in the month. |
Hello! I am facing the same challenge and was very happy to find this thread! Thank you! |
Requested by @Princen in #31
The text was updated successfully, but these errors were encountered: