Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

snapshotEngine: loops/functions in zip-and-upload instead of copy paste repetitions #491

Open
orcutt989 opened this issue Oct 6, 2022 · 1 comment
Open

snapshotEngine: loops/functions in zip-and-upload instead of copy paste repetitions #491

orcutt989 opened this issue Oct 6, 2022 · 1 comment
Labels
bash snapshot-engine tech-debt

Comments

@orcutt989
Copy link
Contributor

The bash in zip-and-upload.sh could be substantially reduced by implementing functions and loops. Much of the copy-paste is left over from POC during development of the snapshot engine. Our velocity has been towards incremental features and not so much about tech-debt/improvements so that is why this is still the way it is.

Specifically there could be a metadata, LZ4/upload functions and loops that would reduce the lines of code by the 100s.
@orcutt989
Copy link
Contributor Author

@nicolasochem I made this issue per our tech-debt discussion on how to improve zip-and-upload.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bash snapshot-engine tech-debt
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@orcutt989