Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown-link-check is now unusable with autogenerated tables of contents #4079

Closed
chris-grabcad opened this issue Oct 2, 2024 · 2 comments
Labels
bug Something isn't working O: stale 🤖 This issue or pull request is stale, it will be closed if there is no activity

Comments

@chris-grabcad
Copy link

Describe the bug
A clear and concise description of what the bug is.

This is a bug in 3.12.x of markdown-link-check which falesly markes autogenated
TOC links as unreachable, for example this piece of markdown will be flagged by
markdown-link-check v 3.12.x, but not by 3.11.x

[migrating from <= v1.18.0](#migrating-from--v1180)

### Migrating from `<= v1.18.0`

This is copied directly from tcort/markdown-link-check#358

Expected behavior
Mega linter should produce consistent, noiseless and silencable errors.

Additional context
Downgrading markdown-link-check to v 3.11.x would be a workaround, but we cannot control the versions
of linters in megalinter :-(.

We could try using an earlier version of megalinter, but I believe that a different linter gives issues with
our repo under those circumstances.

@chris-grabcad chris-grabcad added the bug Something isn't working label Oct 2, 2024
@nvuillam
Copy link
Member

nvuillam commented Oct 4, 2024

You could disable markdown links check and try lychee instead, scopi'g only markdown files if you don't want to check links on other files

It's way faster and might replace markdown links check in a future major version :)

Copy link
Contributor

github-actions bot commented Nov 4, 2024

This issue has been automatically marked as stale because it has not had recent activity.
It will be closed in 14 days if no further activity occurs.
Thank you for your contributions.

If you think this issue should stay open, please remove the O: stale 🤖 label or comment on the issue.

@github-actions github-actions bot added the O: stale 🤖 This issue or pull request is stale, it will be closed if there is no activity label Nov 4, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working O: stale 🤖 This issue or pull request is stale, it will be closed if there is no activity
Projects
None yet
Development

No branches or pull requests

2 participants