Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Case-Insensitive Matching in @ExcelColumnName Annotations #327

Closed
jmrsnt opened this issue Jan 9, 2025 · 3 comments
Closed

Comments

@jmrsnt
Copy link

jmrsnt commented Jan 9, 2025

It would be a valuable enhancement to add support for case-insensitive column name matching in the @ExcelColumnName annotation. This feature could be implemented through an optional parameter, such as ignoreCase, with a default value of false.

When ignoreCase is set to true, the library would match column names in a case-insensitive manner, allowing for greater flexibility when working with Excel sheets where column headers may not exactly match the case defined in the @ExcelColumnName annotation.

Example Usage:

@ExcelColumnName(value = "ColumnName", ignoreCase = true)
private String someField;

In this example, the column header could be ColumnName, columnname, COLUMNNAME, or any other case variation.

This feature would simplify integration and improve usability, especially in scenarios where column headers may not have a consistent case across different Excel files.

If this enhancement makes sense for the project, I would be happy to work on its implementation and submit a pull request.

Copy link

github-actions bot commented Jan 9, 2025

Thank you for contributing to Poiji! Feel free to create a PR If you want to contribute directly :)

@ozlerhakan
Copy link
Owner

Hi @jmrsnt ,

Thank you for the comprehensive suggestion on the topic! I hope you refer to a feature that Poiji has supported for a while among the PoijiOptions features; Have your tried out PoijiOptionsBuilder#caseInsensitive(boolean) for your use cases? Is this what you're looking for?

Thanks!

@jmrsnt
Copy link
Author

jmrsnt commented Jan 17, 2025

Hi,

Yes, that's exactly what I was looking for. Thank you for pointing it out!

@jmrsnt jmrsnt closed this as completed Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants