Adding inverse sine function #77
Conversation
Adding new constant "inverseSin" into class "MonoOperatorModes". Adding new if statement "if (newMode == MonoOperatorModes.inverseSin)" into class "calculateMono"
The outputs of CalculateMonoSinTest(), CalculateMonoCosTest(), and CalculateMonoTanTest() were not matched with the expected answers because of the logic error. The logic error was solved by adding "Math.toDegrees()" Adding CalculateMonoInverseSinTest() to test the inverse sine function
jorianCheong
changed the title
|
@pH-7 @achinthagunasekara @hczhcz @xatza please to review my pull request, thank you very much |
|
Thanks very much for this! I really appreciate your time improving the project! 💯 Could you let me know on what Java version you have tested your changes? PS, can you commit To do so, you can generate a new jar file with the following CLI command when you are in the |
|
Let me know if you need any help @jorianCheong 🙂 Hopefully what I suggested makes sense to you 😀 |
|
Hi @jorianCheong 🙂 I hope you are well! Could you let me know when you can? |
There was a problem hiding this comment.
-
Could you let me know on what Java version you have tested your changes?
-
Can you commit
SimpleJavaCalculator.jarcontaining your changes, and run it?
To do so, you can generate a new jar file with the following CLI command when you are in thesrc/directoryjar cmvf ../manifest.mf ../SimpleJavaCalculator.jar simplejavacalculator/*.class
Adding new constant "inverseSin" into class "MonoOperatorModes".
Adding new if statement "if (newMode == MonoOperatorModes.inverseSin)" into class "calculateMono"