-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggest 'components' be placed before 'props' #62
Comments
Hello @fritx ! "But... Why?" You may ask. I believe I love having the props all the way up, because, usually, that's what really matters to me when using components. What do you think? |
@pablohpsilva Hah, thanks for your reply!
I'm very agreed with that, and I think, "Birds of a feather flock together", The accepted values of For example, in one of my libraries: import { PositionalAudio, AudioLoader } from 'three'
import Object3D from './Object3D'
export default {
name: 'PositionalAudio',
mixins: [Object3D],
components: { Object3D },
inject: ['global'],
props: {
refDistance: { type: Number, default: 10 },
volume: { type: Number, default: 1 },
paused: Boolean,
loop: Boolean,
url: String
}, |
https://github.com/pablohpsilva/vuejs-component-style-guide#why-6
I suggest
components
be placed afterextends
and beforeprops
,because it is intensively related to the
<template>
on top, and nothing else.like: https://github.com/vuejs/vue-hackernews-2.0/blob/master/src/views/ItemList.vue
I suffer from scrolling too much, and think it is not
relational(rational).Any thoughts?
Cheers!
The text was updated successfully, but these errors were encountered: