Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

%7d is } not ~ #4

Closed
Kifir22 opened this issue Jun 19, 2018 · 1 comment
Closed

%7d is } not ~ #4

Kifir22 opened this issue Jun 19, 2018 · 1 comment

Comments

@Kifir22
Copy link

Kifir22 commented Jun 19, 2018

cpe/src/Naming/CPENameBinder.php

Line 299 in 9b4f6bc

return "%7d";

"%7e": result := strcat(result,"\~") not %7d
godsgood33 added a commit to godsgood33/cpe that referenced this issue Aug 22, 2018
@godsgood33
LogicalValue.php - Added use Exception
8465c63 
Utilities.php - Fixed isAlphanum method so it could look for more than one character and am returning explicit booleans
Corrected PHPDoc comments throughout (some missing type altogether)
Fixed issue pacificsec#2, pacificsec#3, & pacificsec#4
@godsgood33 godsgood33 mentioned this issue Aug 22, 2018
Merged
@antoniomrfranco
Copy link
Collaborator

antoniomrfranco commented Aug 22, 2018 •
edited
Loading

Fixed in #5.
Thanks to @Kifir22 and @godsgood33.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@antoniomrfranco @Kifir22