Fix typechecking errors

Author: mattt

lib/package_url.rb

@@ -72,7 +72,14 @@ def initialize(type:, name:, namespace: nil, version: nil, qualifiers: nil, subp
   # @raise [InvalidPackageURL] If the string is not a valid package URL.
   # @return [PackageURL]
   def self.parse(string)
-    components = {}
+    components = {
+      type: nil,
+      namespace: nil,
+      name: nil,
+      version: nil,
+      qualifiers: nil,
+      subpath: nil
+    }
 
     # Split the purl string once from right on '#'
     # - The left side is the remainder
@@ -195,8 +202,16 @@ def self.parse(string)
       components[:namespace] = nil
     end
 
-    new(type: components[:type],
-        name: components[:name],
+    # Ensure type and name are not nil before creating the PackageURL instance
+    raise InvalidPackageURL, 'missing package type' if components[:type].nil?
+    raise InvalidPackageURL, 'missing package name' if components[:name].nil?
+
+    # Create a new PackageURL with validated components
+    type = components[:type] || ''  # This ensures type is never nil
+    name = components[:name] || ''  # This ensures name is never nil
+
+    new(type: type,
+        name: name,
         namespace: components[:namespace],
         version: components[:version],
         qualifiers: components[:qualifiers],

sig/package_url.rbs

@@ -1,6 +1,9 @@
 class PackageURL
   VERSION: String
 
+  class InvalidPackageURL < ArgumentError
+  end
+
   def scheme: () -> String
   attr_reader type: String
   attr_reader namespace: String?
@@ -9,32 +12,32 @@ class PackageURL
   attr_reader qualifiers: Hash[String, String]?
   attr_reader subpath: String?
 
-  def initialize: (type: String `type`, 
-                   ?namespace: String? namespace, 
-                   name: String name, 
-                   ?version: String? version, 
-                   ?qualifiers: Hash[String, String]? qualifiers, 
+  def initialize: (type: String `type`,
+                   ?namespace: String? namespace,
+                   name: String name,
+                   ?version: String? version,
+                   ?qualifiers: Hash[String, String]? qualifiers,
                    ?subpath: String? subpath) -> void
-                
-  def self.parse: (String string) -> PackageURL?
-
-  def to_h: () -> { scheme: String, 
-                    type: String, 
-                    namespace: String?, 
-                    name: String?, 
-                    version: String?, 
-                    qualifiers: Hash[String, String]?, 
+
+  def self.parse: (String string) -> PackageURL
+
+  def to_h: () -> { scheme: String,
+                    type: String,
+                    namespace: String?,
+                    name: String?,
+                    version: String?,
+                    qualifiers: Hash[String, String]?,
                     subpath: String? }
 
   def to_s: () -> String
 
   def deconstruct: () -> Array[String | Hash[String, String] | nil]
 
-  def deconstruct_keys: (Array[Symbol] keys) -> { scheme: String, 
-                                                  type: String, 
-                                                  namespace: String?, 
-                                                  name: String?, 
-                                                  version: String?, 
-                                                  qualifiers: Hash[String, String]?, 
+  def deconstruct_keys: (Array[Symbol] keys) -> { scheme: String,
+                                                  type: String,
+                                                  namespace: String?,
+                                                  name: String?,
+                                                  version: String?,
+                                                  qualifiers: Hash[String, String]?,
                                                   subpath: String? }
 end