pull_from_upstream fails if there is trailing whitespace at the end of the Source URL in the spec #392
Closed
1 of 2 tasks
Labels
area/fedora
Related to Fedora ecosystem
complexity/easy-fix
No planning/thinking about design needed, should be finished in an hour.
gain/low
This doesn't bring that much value to users.
impact/low
This issue impacts only a few users.
kind/bug
Something isn't working.
workaround-exists
There is an existing workaround that can be used in the meantime of implementing the issue.
What happened? What is the problem?
When enabling Packit on
python-request
: https://src.fedoraproject.org/rpms/python-result/pull-request/1I noticed that the first attempt by Packit fails, it turns out because the URL it's trying to retrieve from GitHub contains the trailing whitespace.
Once I remove the whitespace - see https://src.fedoraproject.org/rpms/python-result/c/1cf1485de2417dbf9c6578ce1ceb5db651ac4368?branch=rawhide - land, and retry, Packit produces the PR to update the package just fine
What did you expect to happen?
Trailing whitespaces should be trimmed before processing
Example URL(s)
Retrieving this fails
wget -cN "https://github.com/rustedpy/result/archive/v0.17.0/result-0.17.0.tar.gz "
But this succeeds
wget -cN "https://github.com/rustedpy/result/archive/v0.17.0/result-0.17.0.tar.gz"
Steps to reproduce
1. Add whitespace to the source URL of a package 2. packit pull-from-upstream
Workaround
Participation
The text was updated successfully, but these errors were encountered: