Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pull_from_upstream fails if there is trailing whitespace at the end of the Source URL in the spec #392

Closed
1 of 2 tasks
michel-slm opened this issue Jun 27, 2024 · 0 comments · Fixed by #393
Closed
1 of 2 tasks
Labels
area/fedora Related to Fedora ecosystem complexity/easy-fix No planning/thinking about design needed, should be finished in an hour. gain/low This doesn't bring that much value to users. impact/low This issue impacts only a few users. kind/bug Something isn't working. workaround-exists There is an existing workaround that can be used in the meantime of implementing the issue.

Comments

@michel-slm
Copy link

What happened? What is the problem?

When enabling Packit on python-request: https://src.fedoraproject.org/rpms/python-result/pull-request/1

I noticed that the first attempt by Packit fails, it turns out because the URL it's trying to retrieve from GitHub contains the trailing whitespace.

Once I remove the whitespace - see https://src.fedoraproject.org/rpms/python-result/c/1cf1485de2417dbf9c6578ce1ceb5db651ac4368?branch=rawhide - land, and retry, Packit produces the PR to update the package just fine

What did you expect to happen?

Trailing whitespaces should be trimmed before processing

Example URL(s)

Retrieving this fails

wget -cN "https://github.com/rustedpy/result/archive/v0.17.0/result-0.17.0.tar.gz "

But this succeeds

wget -cN "https://github.com/rustedpy/result/archive/v0.17.0/result-0.17.0.tar.gz"

Steps to reproduce

1. Add whitespace to the source URL of a package
2. packit pull-from-upstream

Workaround

  • There is an existing workaround that can be used until this issue is fixed.

Participation

  • I am willing to submit a pull request for this issue. (Packit team is happy to help!)
@nforro nforro transferred this issue from packit/packit Jul 1, 2024
@nforro nforro added kind/bug Something isn't working. area/fedora Related to Fedora ecosystem complexity/easy-fix No planning/thinking about design needed, should be finished in an hour. gain/low This doesn't bring that much value to users. impact/low This issue impacts only a few users. workaround-exists There is an existing workaround that can be used in the meantime of implementing the issue. labels Jul 1, 2024
@nforro nforro moved this from new to backlog in Packit Kanban Board Jul 1, 2024
@nforro nforro moved this from backlog to in-review in Packit Kanban Board Jul 1, 2024
@github-project-automation github-project-automation bot moved this from in-review to done in Packit Kanban Board Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/fedora Related to Fedora ecosystem complexity/easy-fix No planning/thinking about design needed, should be finished in an hour. gain/low This doesn't bring that much value to users. impact/low This issue impacts only a few users. kind/bug Something isn't working. workaround-exists There is an existing workaround that can be used in the meantime of implementing the issue.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants