Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add valid property to sources #295

Merged
merged 2 commits into from
Oct 26, 2023
Merged

Add valid property to sources #295

merged 2 commits into from
Oct 26, 2023

Conversation

nforro
Copy link
Member

@nforro nforro commented Oct 25, 2023

Related to packit/packit#2129.

RELEASE NOTES BEGIN

Sources now have a valid property that indicates whether a source is valid in the current context, meaning it is not present in a false branch of any condition.

RELEASE NOTES END

@gotmax23
Copy link
Contributor

Note that conditionalizing Sources or Patches is a code smell and can have negative consequences (see e.g., https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/#_do_not_conditionalize_sources), but I guess it's still valid to implement this...

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/6685e15554ba4cf584cc0ab821a38b89

✔️ pre-commit SUCCESS in 25m 34s
✔️ specfile-tests-rpm-deps SUCCESS in 1m 02s
✔️ specfile-tests-pip-deps SUCCESS in 59s

@nforro nforro mentioned this pull request Oct 25, 2023
Merged
lbarcziova
lbarcziova approved these changes Oct 26, 2023
View reviewed changes
Copy link
Member

@lbarcziova lbarcziova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nforro
Copy link
Member Author

nforro commented Oct 26, 2023

/packit rebuild-failed

@nforro nforro added the mergeit Zuul, merge it! label Oct 26, 2023
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://softwarefactory-project.io/zuul/t/packit-service/buildset/b5f9c50267ec4cf1a85e4a11650ade33

✔️ pre-commit SUCCESS in 4m 10s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 39bcedf into main Oct 26, 2023
28 checks passed
@delete-merged-branch delete-merged-branch bot deleted the sources branch October 26, 2023 09:12
@lachmanfrantisek
Copy link
Member

Note that conditionalizing Sources or Patches is a code smell and can have negative consequences (see e.g., https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/#_do_not_conditionalize_sources), but I guess it's still valid to implement this...

Maybe, we can warn the user and link this paragraph once we find such a case..;)

softwarefactory-project-zuul bot added a commit to packit/packit that referenced this pull request Oct 30, 2023
@softwarefactory-project-zuul
Do not download sources excluded using spec file conditions (#2132)
b618e76 
Do not download sources excluded using spec file conditions

Fixes #2129.
Merge after packit/specfile#295.
RELEASE NOTES BEGIN
Packit no longer downloads sources excluded using spec file conditions.
RELEASE NOTES END

Reviewed-by: Laura Barcziová
Reviewed-by: František Lachman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbarcziova lbarcziova lbarcziova approved these changes

Assignees
No one assigned
Labels
mergeit Zuul, merge it!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nforro @gotmax23 @lachmanfrantisek @lbarcziova