Fix update_value()
#340
Merged
Fix update_value()
#340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The implementation didn't account for a case when a macro definition needed to be commented out to succesfully set the new value but it was commented out already. This commit fixes that. Signed-off-by: Nikola Forró <[email protected]>
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 49s |
lachmanfrantisek
approved these changes
Jan 8, 2024
Comment on lines
+793
to
+794
| m = regex.match(requested_value) | ||
| if not m: |
There was a problem hiding this comment.
I am wondering if walrus can help here..;)
There was a problem hiding this comment.
We can't use that, specfile still has to support Python 3.6.
lbarcziova
approved these changes
Jan 8, 2024
|
Build succeeded (gate pipeline). ✔️ pre-commit SUCCESS in 1m 44s |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation didn't account for a case when a macro definition needed to be commented out to succesfully set the new value but it was commented out already. This commit fixes that.