Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate API documentation from docstrings #343

Merged
merged 3 commits into from
Jan 12, 2024
Merged

Generate API documentation from docstrings #343

merged 3 commits into from
Jan 12, 2024

Conversation

nforro
Copy link
Member

@nforro nforro commented Jan 12, 2024

No description provided.

@nforro nforro mentioned this pull request Jan 12, 2024
Merged
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/db1484bc5e3a46b6bf884b1434c273a3

✔️ pre-commit SUCCESS in 1m 57s
✔️ specfile-tests-rpm-deps SUCCESS in 1m 07s
✔️ specfile-tests-pip-deps SUCCESS in 1m 06s

@nforro
Improve docstrings
76db6a4 
Signed-off-by: Nikola Forró <[email protected]>
majamassarini
majamassarini approved these changes Jan 12, 2024
View reviewed changes
Copy link
Member

@majamassarini majamassarini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe I would add a comment to the EscapeBracketsProcessor because I am not really sure to understand why you need it 😅🙏

lbarcziova
lbarcziova approved these changes Jan 12, 2024
View reviewed changes
Copy link
Member

@lbarcziova lbarcziova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/5012e31c4c084193b34bba9acb745ce4

✔️ pre-commit SUCCESS in 2m 11s
✔️ specfile-tests-rpm-deps SUCCESS in 1m 13s
✔️ specfile-tests-pip-deps SUCCESS in 1m 09s

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/0d51917f40ea46d8a61c0534b4fbeca4

✔️ pre-commit SUCCESS in 2m 12s
✔️ specfile-tests-rpm-deps SUCCESS in 1m 18s
✔️ specfile-tests-pip-deps SUCCESS in 1m 13s

@nforro nforro added the mergeit Zuul, merge it! label Jan 12, 2024
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://softwarefactory-project.io/zuul/t/packit-service/buildset/3bc8617865f54b4f8446727eb650f031

✔️ pre-commit SUCCESS in 2m 16s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 58fa4a9 into main Jan 12, 2024
21 of 27 checks passed
@delete-merged-branch delete-merged-branch bot deleted the docs branch January 12, 2024 11:41
nforro added a commit to packit/packit.dev that referenced this pull request Jan 12, 2024
@nforro
Add specfile docs (#805)
021502d 
Merge after packit/specfile#343.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbarcziova lbarcziova lbarcziova approved these changes

@majamassarini majamassarini majamassarini approved these changes

Assignees
No one assigned
Labels
mergeit Zuul, merge it!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nforro @majamassarini @lbarcziova