-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ci/improvements #350
Ci/improvements #350
Conversation
* Remove PR template that's taken from packit/.github repository * Add release notes check Signed-off-by: Matej Focko <[email protected]>
Related to packit/.github#9 Signed-off-by: Matej Focko <[email protected]>
jobs: | ||
check_release_notes: | ||
name: Notes are either written, or there are none | ||
uses: packit/.github/.github/workflows/check-release-notes.yml@main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be:
uses: packit/.github/.github/workflows/check-release-notes.yml@main | |
uses: packit/.github/workflows/check-release-notes.yml@main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It used to be that, but it screws up the path deduction, cause you can have the action in the repo, but also reuse it from other of your repos… so I had to move it there :/
It's this path:
https://github.com/packit/.github/blob/main/.github/workflows/check-release-notes.yml
I probably could move it somewhere else? Or have a separate repo, this seems like reasonable option right now 🤷
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I see. A repo name starting with a dot is a bit confusing 🙂
Build succeeded. ✔️ pre-commit SUCCESS in 3m 59s |
Signed-off-by: Matej Focko <[email protected]>
Build succeeded. ✔️ pre-commit SUCCESS in 2m 10s |
No description provided.