Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ci/improvements #350

Merged
merged 3 commits into from
Feb 21, 2024
Merged

Ci/improvements #350

merged 3 commits into from
Feb 21, 2024

Conversation

mfocko
Copy link
Member

@mfocko mfocko commented Feb 20, 2024

No description provided.

* Remove PR template that's taken from packit/.github repository
* Add release notes check

Signed-off-by: Matej Focko <[email protected]>
jobs:
check_release_notes:
name: Notes are either written, or there are none
uses: packit/.github/.github/workflows/check-release-notes.yml@main
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be:

Suggested change
uses: packit/.github/.github/workflows/check-release-notes.yml@main
uses: packit/.github/workflows/check-release-notes.yml@main

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It used to be that, but it screws up the path deduction, cause you can have the action in the repo, but also reuse it from other of your repos… so I had to move it there :/

It's this path:
https://github.com/packit/.github/blob/main/.github/workflows/check-release-notes.yml

I probably could move it somewhere else? Or have a separate repo, this seems like reasonable option right now 🤷

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I see. A repo name starting with a dot is a bit confusing 🙂

Copy link
Contributor

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/a6db26f788684dbf8c53c21dcdde6dc3

✔️ pre-commit SUCCESS in 3m 59s
✔️ specfile-tests-rpm-deps SUCCESS in 1m 09s
✔️ specfile-tests-pip-deps SUCCESS in 1m 04s

Copy link
Contributor

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/c12a82b6d6dc47a693bc73c6b5e86fbe

✔️ pre-commit SUCCESS in 2m 10s
✔️ specfile-tests-rpm-deps SUCCESS in 1m 07s
✔️ specfile-tests-pip-deps SUCCESS in 1m 05s

@mfocko mfocko merged commit aae45c8 into packit:main Feb 21, 2024
29 checks passed
@mfocko mfocko deleted the ci/improvements branch February 21, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants