From 37df2efce95a67cbecbd03ad6ec02584b35910ae Mon Sep 17 00:00:00 2001 From: vvaibhavv11 Date: Thu, 22 Aug 2024 12:50:55 +0530 Subject: [PATCH 1/4] add the new package libcs50-git --- packagelist | 1 + packages/libcs50-git/.SRCINFO | 9 ++++++++ packages/libcs50-git/libcs50-git.pacscript | 25 ++++++++++++++++++++++ srclist | 10 +++++++++ 4 files changed, 45 insertions(+) create mode 100644 packages/libcs50-git/.SRCINFO create mode 100644 packages/libcs50-git/libcs50-git.pacscript diff --git a/packagelist b/packagelist index 7070e70ace..6a3ff79a57 100644 --- a/packagelist +++ b/packagelist @@ -252,6 +252,7 @@ lemonbar-xft-git lens lf-bin libcamera-git +libcs50-git libcutefish-git libdisplay-info-git libdrm diff --git a/packages/libcs50-git/.SRCINFO b/packages/libcs50-git/.SRCINFO new file mode 100644 index 0000000000..11c4e80457 --- /dev/null +++ b/packages/libcs50-git/.SRCINFO @@ -0,0 +1,9 @@ +pkgbase = libcs50-git + gives = libcs50 + pkgver = 11.0.3 + pkgdesc = Library provided by Harvard University for learning the basic C language + makedepends = make + maintainer = Vaibhav Sharma + source = https://github.com/cs50/libcs50.git + +pkgname = libcs50-git diff --git a/packages/libcs50-git/libcs50-git.pacscript b/packages/libcs50-git/libcs50-git.pacscript new file mode 100644 index 0000000000..885c088bcb --- /dev/null +++ b/packages/libcs50-git/libcs50-git.pacscript @@ -0,0 +1,25 @@ +pkgname="libcs50-git" +gives="libcs50" +pkgver="11.0.3" +source=("https://github.com/cs50/libcs50.git") +makedepends=("make") +maintainer=("Vaibhav Sharma ") +pkgdesc="Library provided by Harvard University for learning the basic C language" + +build() { + cd "${_archive}" + make +} + +package() { + cd "${_archive}" + make DESTDIR="${pkgdir}/usr/local" install || true + + # Manually skip or suppress the ldconfig error + # Skipping ldconfig to avoid read-only filesystem issues + echo "skipping the ldconfig because it gives error doing this after the install" +} + +post_install() { + ldconfig /usr/local/lib +} diff --git a/srclist b/srclist index 400c3ae8fe..7644b4a3af 100644 --- a/srclist +++ b/srclist @@ -5007,6 +5007,16 @@ pkgbase = libcamera-git pkgname = libcamera-git --- +pkgbase = libcs50-git + gives = libcs50 + pkgver = 11.0.3 + pkgdesc = Library provided by Harvard University for learning the basic C language + makedepends = make + maintainer = Vaibhav Sharma + source = https://github.com/cs50/libcs50.git + +pkgname = libcs50-git +--- pkgbase = libcutefish-git gives = libcutefish pkgver = 0.7 From e6a7f3770896dac64bf51f4cae6333d5f359edf9 Mon Sep 17 00:00:00 2001 From: vvaibhavv11 <141448219+vvaibhavv11@users.noreply.github.com> Date: Fri, 23 Aug 2024 00:48:33 +0530 Subject: [PATCH 2/4] Update packages/libcs50-git/libcs50-git.pacscript Co-authored-by: Elsie --- packages/libcs50-git/libcs50-git.pacscript | 4 ---- 1 file changed, 4 deletions(-) diff --git a/packages/libcs50-git/libcs50-git.pacscript b/packages/libcs50-git/libcs50-git.pacscript index 885c088bcb..6df5c9c3f3 100644 --- a/packages/libcs50-git/libcs50-git.pacscript +++ b/packages/libcs50-git/libcs50-git.pacscript @@ -14,10 +14,6 @@ build() { package() { cd "${_archive}" make DESTDIR="${pkgdir}/usr/local" install || true - - # Manually skip or suppress the ldconfig error - # Skipping ldconfig to avoid read-only filesystem issues - echo "skipping the ldconfig because it gives error doing this after the install" } post_install() { From f0978f53fa179e179c800fbd7b76b98cadcffe67 Mon Sep 17 00:00:00 2001 From: vvaibhavv11 <141448219+vvaibhavv11@users.noreply.github.com> Date: Fri, 23 Aug 2024 00:58:24 +0530 Subject: [PATCH 3/4] Apply suggestions from code review When the time of writing this I have thought of add this, but you know the build is so small that it does not make much of difference in time, that is why I decided to not add this. It is good to practice the right thing. Co-authored-by: Elsie --- packages/libcs50-git/libcs50-git.pacscript | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/libcs50-git/libcs50-git.pacscript b/packages/libcs50-git/libcs50-git.pacscript index 6df5c9c3f3..ae6efcee4b 100644 --- a/packages/libcs50-git/libcs50-git.pacscript +++ b/packages/libcs50-git/libcs50-git.pacscript @@ -8,7 +8,7 @@ pkgdesc="Library provided by Harvard University for learning the basic C languag build() { cd "${_archive}" - make + make -j"${NCPU}" } package() { From 4f34c2adb787b47300921a3f301a3a68ee11a089 Mon Sep 17 00:00:00 2001 From: vvaibhavv11 Date: Fri, 23 Aug 2024 01:03:01 +0530 Subject: [PATCH 4/4] add suggestion --- packages/libcs50-git/libcs50-git.pacscript | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/libcs50-git/libcs50-git.pacscript b/packages/libcs50-git/libcs50-git.pacscript index ae6efcee4b..335d935c55 100644 --- a/packages/libcs50-git/libcs50-git.pacscript +++ b/packages/libcs50-git/libcs50-git.pacscript @@ -7,12 +7,12 @@ maintainer=("Vaibhav Sharma ") pkgdesc="Library provided by Harvard University for learning the basic C language" build() { - cd "${_archive}" + cd "${gives}" make -j"${NCPU}" } package() { - cd "${_archive}" + cd "${gives}" make DESTDIR="${pkgdir}/usr/local" install || true }