-
-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for disabling colored output #340
Comments
I can take a stab at implementing this, since it doesn't look too difficult.
I'm leaning towards option 2, to preserve colored output ppl expect. |
Here's my stab at it, but having trouble running tests locally - something something avro something. |
Hey thanks for this, option 2 sounds better for me. You might need the avro plugin downloaded locally, we should document that in a contributing / developing guide.
Lines 43 to 49 in b93338e
|
contrib guide states run
|
I tried make deps and make download_plugins and that's when the error changed from missing plugin to an error in the avro plugin. |
yeah thats a complete aside, it's irrelevant for your PR. I'll leave the decision on merging and any code style comments to the maintainer, I've tagged him for review 👍🏾 I assume you've built this locally and tested out that you get the expected behaviour in your use case? |
Thanks for the PR, will merge once feedback is in :) |
Our team is trying to display pact provider verification results in PRs. To do that, we parse the test output and grab the pact provider summary.
However, it contains ANSI color codes by default, which we remove via a hairy regex.
It seems pact ffi already supports disabling colors via
pactffi_verifier_set_coloured_output
function here -pact-go/internal/native/pact.h
Line 2734 in b93338e
so it looks like it's just a matter of exposing it via VerifyRequest
The text was updated successfully, but these errors were encountered: