Padrino (v. 0.15.3) fails to start with Ruby 3.3.0: uninitialized constant Padrino::Rackup (NameError)

[kimberlykeilymh]

Do you want to request a feature or report a bug?

Bug

What is the current behavior?

Failure to start server using Ruby 3.3.0. Below is the stack trace.

$ bundle exec padrino s
bundler: failed to load command: padrino (/home/kimberly/.gem/ruby/3.3.0/bin/padrino)
/home/kimberly/.gem/ruby/3.3.0/bundler/gems/padrino-framework-d75858b05d9c/padrino-core/lib/padrino-core/server.rb:33:in `<module:Padrino>': uninitialized constant Padrino::Rackup (NameError)

  class Server < Rackup::Server
                 ^^^^^^
	from /home/kimberly/.gem/ruby/3.3.0/bundler/gems/padrino-framework-d75858b05d9c/padrino-core/lib/padrino-core/server.rb:1:in `<top (required)>'
	from /home/kimberly/.rubies/ruby-3.3.0/lib/ruby/3.3.0/bundled_gems.rb:74:in `require'
	from /home/kimberly/.rubies/ruby-3.3.0/lib/ruby/3.3.0/bundled_gems.rb:74:in `block (2 levels) in replace_require'
	from /home/kimberly/.gem/ruby/3.3.0/bundler/gems/padrino-framework-d75858b05d9c/padrino-core/lib/padrino-core.rb:15:in `<top (required)>'
	from /home/kimberly/.rubies/ruby-3.3.0/lib/ruby/3.3.0/bundled_gems.rb:74:in `require'
	from /home/kimberly/.rubies/ruby-3.3.0/lib/ruby/3.3.0/bundled_gems.rb:74:in `block (2 levels) in replace_require'
	from /home/kimberly/.gem/ruby/3.3.0/bundler/gems/padrino-framework-d75858b05d9c/padrino/lib/padrino.rb:3:in `<top (required)>'
	from <internal:/home/kimberly/.rubies/ruby-3.3.0/lib/ruby/3.3.0/rubygems/core_ext/kernel_require.rb>:37:in `require'
	from <internal:/home/kimberly/.rubies/ruby-3.3.0/lib/ruby/3.3.0/rubygems/core_ext/kernel_require.rb>:37:in `require'
	from /home/kimberly/.rubies/ruby-3.3.0/lib/ruby/3.3.0/bundled_gems.rb:74:in `block (2 levels) in replace_require'
	from /home/kimberly/.gem/ruby/3.3.0/gems/bundler-2.5.9/lib/bundler/runtime.rb:60:in `block (2 levels) in require'
	from /home/kimberly/.gem/ruby/3.3.0/gems/bundler-2.5.9/lib/bundler/runtime.rb:55:in `each'
	from /home/kimberly/.gem/ruby/3.3.0/gems/bundler-2.5.9/lib/bundler/runtime.rb:55:in `block in require'
	from /home/kimberly/.gem/ruby/3.3.0/gems/bundler-2.5.9/lib/bundler/runtime.rb:44:in `each'
	from /home/kimberly/.gem/ruby/3.3.0/gems/bundler-2.5.9/lib/bundler/runtime.rb:44:in `require'
	from /home/kimberly/.gem/ruby/3.3.0/gems/bundler-2.5.9/lib/bundler.rb:187:in `require'
	from /home/kimberly/.rubies/ruby-3.3.0/lib/ruby/3.3.0/bundled_gems.rb:74:in `require'
	from /home/kimberly/.rubies/ruby-3.3.0/lib/ruby/3.3.0/bundled_gems.rb:74:in `block (2 levels) in replace_require'
	from /home/kimberly/.gem/ruby/3.3.0/bundler/gems/padrino-framework-d75858b05d9c/padrino-core/lib/padrino-core/cli/launcher.rb:25:in `start'
	from /home/kimberly/.gem/ruby/3.3.0/gems/thor-1.3.1/lib/thor/command.rb:28:in `run'
	from /home/kimberly/.gem/ruby/3.3.0/gems/thor-1.3.1/lib/thor/invocation.rb:127:in `invoke_command'
	from /home/kimberly/.gem/ruby/3.3.0/gems/thor-1.3.1/lib/thor.rb:527:in `dispatch'
	from /home/kimberly/.gem/ruby/3.3.0/gems/thor-1.3.1/lib/thor/base.rb:584:in `start'
	from /home/kimberly/.gem/ruby/3.3.0/bundler/gems/padrino-framework-d75858b05d9c/padrino-core/bin/padrino:9:in `<top (required)>'
	from /home/kimberly/.gem/ruby/3.3.0/bin/padrino:25:in `load'
	from /home/kimberly/.gem/ruby/3.3.0/bin/padrino:25:in `<top (required)>'
	from /home/kimberly/.gem/ruby/3.3.0/gems/bundler-2.5.9/lib/bundler/cli/exec.rb:58:in `load'
	from /home/kimberly/.gem/ruby/3.3.0/gems/bundler-2.5.9/lib/bundler/cli/exec.rb:58:in `kernel_load'
	from /home/kimberly/.gem/ruby/3.3.0/gems/bundler-2.5.9/lib/bundler/cli/exec.rb:23:in `run'
	from /home/kimberly/.gem/ruby/3.3.0/gems/bundler-2.5.9/lib/bundler/cli.rb:451:in `exec'
	from /home/kimberly/.gem/ruby/3.3.0/gems/bundler-2.5.9/lib/bundler/vendor/thor/lib/thor/command.rb:28:in `run'
	from /home/kimberly/.gem/ruby/3.3.0/gems/bundler-2.5.9/lib/bundler/vendor/thor/lib/thor/invocation.rb:127:in `invoke_command'
	from /home/kimberly/.gem/ruby/3.3.0/gems/bundler-2.5.9/lib/bundler/vendor/thor/lib/thor.rb:527:in `dispatch'
	from /home/kimberly/.gem/ruby/3.3.0/gems/bundler-2.5.9/lib/bundler/cli.rb:34:in `dispatch'
	from /home/kimberly/.gem/ruby/3.3.0/gems/bundler-2.5.9/lib/bundler/vendor/thor/lib/thor/base.rb:584:in `start'
	from /home/kimberly/.gem/ruby/3.3.0/gems/bundler-2.5.9/lib/bundler/cli.rb:28:in `start'
	from /home/kimberly/.gem/ruby/3.3.0/gems/bundler-2.5.9/exe/bundle:28:in `block in <top (required)>'
	from /home/kimberly/.gem/ruby/3.3.0/gems/bundler-2.5.9/lib/bundler/friendly_errors.rb:117:in `with_friendly_errors'
	from /home/kimberly/.gem/ruby/3.3.0/gems/bundler-2.5.9/exe/bundle:20:in `<top (required)>'
	from /home/kimberly/.rubies/ruby-3.3.0/bin/bundle:25:in `load'
	from /home/kimberly/.rubies/ruby-3.3.0/bin/bundle:25:in `<main>'

What is the expected behavior?

Start the server without errors.

Which versions of Ruby, Padrino, Sinatra, Rack, OS are you using? Did this work in previous versions?

Ruby 3.3.0, Padrino 0.15.3, Ubuntu 23.10.

[nesquena]

@achiurizo would this be fixed with a release from master? Would be great to cut a release that supports Ruby 3.3

[kimberlykeilymh]

Something to mention is that I am using the git repository as a source code, I mean, in my Gemfle it is as follows: gem 'padrino', git: 'https://github.com/padrino/padrino-framework'

[achiurizo]

@kimberlykeilymh thank you for the report! I've pushed out #2289 which should resolve this (adds rackup). If you want to test this sooner, you can try using the branch directly until its merged:

gem 'padrino', git: 'https://github.com/padrino/padrino-framework', branch: 'achiurizo/add-rackup-to-gemspec'

@nesquena we should do more testing after #2289 but after that I think we can go ahead and cut a release

[nesquena]

I went ahead and merged that change. Let us know if that fixes things for you. If everything is working as expected, we can do final testing and cut a release

[kimberlykeilymh]

Thanks guys! The change fixed the bug with rackup.

Although now I get this other error:

bundler: failed to load command: padrino (/home/kimberly/.gem/ruby/3.3.0/bin/padrino)
/home/kimberly/.gem/ruby/3.3.0/bundler/gems/padrino-framework-889f6623c071/padrino-core/lib/padrino-core/server.rb:24:in `detect_application': undefined method `merge' for nil (NoMethodError)

      [rack_app, rack_options.merge(options)]
                             ^^^^^^
	from /home/kimberly/.gem/ruby/3.3.0/bundler/gems/padrino-framework-889f6623c071/padrino-core/lib/padrino-core/server.rb:12:in `run!'
	from /home/kimberly/.gem/ruby/3.3.0/bundler/gems/padrino-framework-889f6623c071/padrino-core/lib/padrino-core/cli/adapter.rb:9:in `start'
	from /home/kimberly/.gem/ruby/3.3.0/bundler/gems/padrino-framework-889f6623c071/padrino-core/lib/padrino-core/cli/launcher.rb:30:in `start'
	from /home/kimberly/.gem/ruby/3.3.0/gems/thor-1.3.1/lib/thor/command.rb:28:in `run'
	from /home/kimberly/.gem/ruby/3.3.0/gems/thor-1.3.1/lib/thor/invocation.rb:127:in `invoke_command'
	from /home/kimberly/.gem/ruby/3.3.0/gems/thor-1.3.1/lib/thor.rb:527:in `dispatch'
	from /home/kimberly/.gem/ruby/3.3.0/gems/thor-1.3.1/lib/thor/base.rb:584:in `start'
	from /home/kimberly/.gem/ruby/3.3.0/bundler/gems/padrino-framework-889f6623c071/padrino-core/bin/padrino:9:in `<top (required)>'
	from /home/kimberly/.gem/ruby/3.3.0/bin/padrino:25:in `load'
	from /home/kimberly/.gem/ruby/3.3.0/bin/padrino:25:in `<top (required)>'
	from /home/kimberly/.gem/ruby/3.3.0/gems/bundler-2.5.9/lib/bundler/cli/exec.rb:58:in `load'
	from /home/kimberly/.gem/ruby/3.3.0/gems/bundler-2.5.9/lib/bundler/cli/exec.rb:58:in `kernel_load'
	from /home/kimberly/.gem/ruby/3.3.0/gems/bundler-2.5.9/lib/bundler/cli/exec.rb:23:in `run'
	from /home/kimberly/.gem/ruby/3.3.0/gems/bundler-2.5.9/lib/bundler/cli.rb:451:in `exec'
	from /home/kimberly/.gem/ruby/3.3.0/gems/bundler-2.5.9/lib/bundler/vendor/thor/lib/thor/command.rb:28:in `run'
	from /home/kimberly/.gem/ruby/3.3.0/gems/bundler-2.5.9/lib/bundler/vendor/thor/lib/thor/invocation.rb:127:in `invoke_command'
	from /home/kimberly/.gem/ruby/3.3.0/gems/bundler-2.5.9/lib/bundler/vendor/thor/lib/thor.rb:527:in `dispatch'
	from /home/kimberly/.gem/ruby/3.3.0/gems/bundler-2.5.9/lib/bundler/cli.rb:34:in `dispatch'
	from /home/kimberly/.gem/ruby/3.3.0/gems/bundler-2.5.9/lib/bundler/vendor/thor/lib/thor/base.rb:584:in `start'
	from /home/kimberly/.gem/ruby/3.3.0/gems/bundler-2.5.9/lib/bundler/cli.rb:28:in `start'
	from /home/kimberly/.gem/ruby/3.3.0/gems/bundler-2.5.9/exe/bundle:28:in `block in <top (required)>'
	from /home/kimberly/.gem/ruby/3.3.0/gems/bundler-2.5.9/lib/bundler/friendly_errors.rb:117:in `with_friendly_errors'
	from /home/kimberly/.gem/ruby/3.3.0/gems/bundler-2.5.9/exe/bundle:20:in `<top (required)>'
	from /home/kimberly/.gem/ruby/3.3.0/bin/bundle:25:in `load'
	from /home/kimberly/.gem/ruby/3.3.0/bin/bundle:25:in `<main>'

Is it also possible to check this error? I can open another issue and close this one if you want.

[nesquena]

@achiurizo hmm, looks like rack_options is nil rather than a hash now in the server start sequence

[srolandmarshall]

@nesquena I built a Padrino app from scratch with limited changes to config (updating database) — using Edge release w/ the inclusion of Backup in the Gemspec results in the issue @kimberlykeilymh mentioned above.

➜  probable-pitchers-padrino git:(main) padrino start
/Users/sam-home/.rvm/gems/ruby-3.1.3/bundler/gems/padrino-framework-889f6623c071/padrino-core/lib/padrino-core/server.rb:24:in `detect_application': undefined method `merge' for nil:NilClass (NoMethodError)

      [rack_app, rack_options.merge(options)]
                             ^^^^^^
        from /Users/sam-home/.rvm/gems/ruby-3.1.3/bundler/gems/padrino-framework-889f6623c071/padrino-core/lib/padrino-core/server.rb:12:in `run!'

Prior to using the Edge release, I was using the default release and included Backup using bundler add rackup to the same issue

[nesquena]

As a starting point, thanks @srolandmarshall I don't want to be too optimistic but it seems like part of this may just be a change to the way Rack parses the files. I had rack options default to {} on #2290 (branch nesquena-rack-options-fix) until achiu may have a chance to test end to end

It's possible this would fix it, but also possible and likely there's larger changes to Rack that need to be adjusted in the core server startup sequence

[srolandmarshall]

Checked it out, seemed to solve the problem on my end. Thanks for the quick patch @nesquena

[nesquena]

Great, thanks for testing! @achiurizo can you merge my PR, and @kimberlykeilymh can you try my patch as well and report back either now or after we merge to master

[kimberlykeilymh]

Hi guys! Yes, that solved the problem and padrino is running without errors. Thanks very much for the fix!

[nesquena]

That's great news, thanks for testing! Since two of you confirmed, perhaps it's time to cut a new release soon

[floriandejonckheere]

Hi! Any news on a new release of Padrino?