feat: [IOCOM-2545] handlePendingMessageState refactor (#7342)

## Short description
refactored said function to handle stored Universal/AppLinks

## List of changes proposed in this pull request
- refactor of said function
- moved linking feature to its own folder, for cleanliness and ease of
expansion
- required tests

## How to test
using the io-dev-api-server on the latest version and reactotron to
check the app state, make sure that:
- opening a link like
`https://cittadini.dev.notifichedigitali.it/io?aar=asd123` opens the app
and displays the SEND flow ( after an authentication screen where
necessary)
- if the app was already open, but in background, then the state key
`features.backgroundLinking` is an empty object
- if it was closed, the same state key displays the open link while in
an authentication screen
- after authentication, said key should be empty again
- the app behaves as normal when woken up by a push notification
interaction
- different URLs, like 
    - `https://cittadini.uat.notifichedigitali.it/io?aar=asd123`
    - `https://cittadini.notifichedigitali.it/io?aar=asd123`
    - `https://cittadini.dev.notifichedigitali.it`
    - `https://cittadini.dev.notifichedigitali.it/io`
    do not wake or open the app.
- URLs also wake the app up when they are the result of a QRcode scan


automated tests should also pass

---------

Co-authored-by: Andrea <[email protected]>

Author: forrest57

ts/features/barcode/screens/BarcodeScanScreen.tsx

@@ -5,19 +5,19 @@ import {
   VSpacer
 } from "@pagopa/io-app-design-system";
 import { useNavigation } from "@react-navigation/native";
+import I18n from "i18next";
 import { Alert, View } from "react-native";
 import ReactNativeHapticFeedback, {
   HapticFeedbackTypes
 } from "react-native-haptic-feedback";
-import I18n from "i18next";
 import { useHardwareBackButton } from "../../../hooks/useHardwareBackButton";
 import { useOpenDeepLink } from "../../../hooks/useOpenDeepLink";
 import { mixpanelTrack } from "../../../mixpanel";
 import {
   AppParamsList,
   IOStackNavigationProp
 } from "../../../navigation/params/AppParamsList";
-import { useIOSelector } from "../../../store/hooks";
+import { useIOSelector, useIOStore } from "../../../store/hooks";
 import {
   barcodesScannerConfigSelector,
   isPnRemoteEnabledSelector
@@ -33,6 +33,7 @@ import { usePagoPaPayment } from "../../payments/checkout/hooks/usePagoPaPayment
 import { PaymentsCheckoutRoutes } from "../../payments/checkout/navigation/routes";
 import { paymentAnalyticsDataSelector } from "../../payments/history/store/selectors";
 import * as paymentsAnalytics from "../../payments/home/analytics";
+import { navigateToSendAarFlow } from "../../pn/aar/utils/deepLinking.ts";
 import * as analytics from "../analytics";
 import { BarcodeScanBaseScreenComponent } from "../components/BarcodeScanBaseScreenComponent";
 import { useIOBarcodeFileReader } from "../hooks/useIOBarcodeFileReader";
@@ -47,15 +48,14 @@ import {
 } from "../types/IOBarcode";
 import { BarcodeFailure } from "../types/failure";
 import { getIOBarcodesByType } from "../utils/getBarcodesByType";
-import { MESSAGES_ROUTES } from "../../messages/navigation/routes.ts";
-import PN_ROUTES from "../../pn/navigation/routes.ts";
 
 const BarcodeScanScreen = () => {
   const navigation = useNavigation<IOStackNavigationProp<AppParamsList>>();
   const openDeepLink = useOpenDeepLink();
   const isIdPayEnabled = useIOSelector(isIdPayLocallyEnabledSelector);
   const paymentAnalyticsData = useIOSelector(paymentAnalyticsDataSelector);
   const isSendEnabled = useIOSelector(isPnRemoteEnabledSelector);
+  const store = useIOStore();
 
   const { startPaymentFlowWithRptId } = usePagoPaPayment();
 
@@ -167,15 +167,7 @@ const BarcodeScanScreen = () => {
         });
         break;
       case "SEND":
-        navigation.navigate(MESSAGES_ROUTES.MESSAGES_NAVIGATOR, {
-          screen: PN_ROUTES.MAIN,
-          params: {
-            screen: PN_ROUTES.QR_SCAN_FLOW,
-            params: {
-              aarUrl: barcode.qrCodeContent
-            }
-          }
-        });
+        navigateToSendAarFlow(store.getState(), barcode.qrCodeContent);
         break;
     }
   };

ts/features/common/store/reducers/__tests__/__snapshots__/index.test.ts.snap

@@ -9,6 +9,7 @@ exports[`featuresPersistor should match snapshot 1`] = `
   "appearanceSettings": {
     "showAppearanceBanner": true,
   },
+  "backgroundLinking": {},
   "connectivityStatus": {
     "isConnected": undefined,
   },

ts/features/common/store/reducers/index.ts

@@ -80,6 +80,10 @@ import {
   activeSessionLoginReducer,
   ActiveSessionLoginState
 } from "../../../authentication/activeSessionLogin/store/reducer";
+import {
+  BackgroundLinkingState,
+  backgroundLinkingReducer
+} from "../../../linking/reducers";
 
 type LoginFeaturesState = {
   testLogin: TestLoginState;
@@ -111,6 +115,7 @@ export type FeaturesState = {
   appFeedback: AppFeedbackState & PersistPartial;
   utmLink: UtmLinkState;
   connectivityStatus: ConnectivityState;
+  backgroundLinking: BackgroundLinkingState;
 };
 
 export type PersistedFeaturesState = FeaturesState & PersistPartial;
@@ -142,7 +147,8 @@ const rootReducer = combineReducers<FeaturesState, Action>({
   landingBanners: landingScreenBannersReducer,
   appFeedback: appFeedbackPersistor,
   utmLink: utmLinkReducer,
-  connectivityStatus: connectivityStateReducer
+  connectivityStatus: connectivityStateReducer,
+  backgroundLinking: backgroundLinkingReducer
 });
 
 const CURRENT_REDUX_FEATURES_STORE_VERSION = 1;

ts/features/identification/sagas/__tests__/identificationSaga.test.ts

@@ -15,7 +15,7 @@ import {
   checkCurrentSession,
   sessionInvalid
 } from "../../../authentication/common/store/actions";
-import { handlePendingMessageStateIfAllowed } from "../../../pushNotifications/sagas/common";
+import { maybeHandlePendingBackgroundActions } from "../../../pushNotifications/sagas/common";
 import { isFastLoginEnabledSelector } from "../../../authentication/fastLogin/store/selectors";
 import { startApplicationInitialization } from "../../../../store/actions/application";
 import { PinString } from "../../../../types/PinString";
@@ -182,7 +182,7 @@ describe("Identification Saga", () => {
       .next()
       .call(testableModule.waitIdentificationResult)
       .next("success")
-      .call(handlePendingMessageStateIfAllowed)
+      .call(maybeHandlePendingBackgroundActions)
       .next()
       .isDone();
   });
@@ -253,7 +253,7 @@ describe("Identification Saga", () => {
       .next()
       .call(testableModule.waitIdentificationResult)
       .next("success")
-      .call(handlePendingMessageStateIfAllowed)
+      .call(maybeHandlePendingBackgroundActions)
       .next()
       .isDone();
   });

ts/features/identification/sagas/index.ts

@@ -24,7 +24,7 @@ import {
 import { PinString } from "../../../types/PinString";
 import { ReduxSagaEffect, SagaCallReturnType } from "../../../types/utils";
 import { deletePin, getPin } from "../../../utils/keychain";
-import { handlePendingMessageStateIfAllowed } from "../../pushNotifications/sagas/common";
+import { maybeHandlePendingBackgroundActions } from "../../pushNotifications/sagas/common";
 import { isFastLoginEnabledSelector } from "../../authentication/fastLogin/store/selectors/index";
 import { isDevEnv } from "../../../utils/environment";
 
@@ -141,8 +141,8 @@ function* startAndHandleIdentificationResult(
   if (identificationResult === IdentificationResult.pinreset) {
     yield* put(startApplicationInitialization());
   } else if (identificationResult === IdentificationResult.success) {
-    // Check if we have a pending notification message
-    yield* call(handlePendingMessageStateIfAllowed);
+    // Check if we have any pending background actions to handle
+    yield* call(maybeHandlePendingBackgroundActions);
   }
 }
 

ts/store/actions/__tests__/__snapshots__/linking.test.ts.snap renamed to ts/features/linking/actions/__test__/__snapshots__/index.test.ts.snap

@@ -1,5 +1,13 @@
 // Jest Snapshot v1, https://goo.gl/fbAQLP
 
+exports[`linking actions should create an action to clear the linking url 1`] = `
+{
+  "meta": undefined,
+  "payload": undefined,
+  "type": "CLEAR_LINKING_URL",
+}
+`;
+
 exports[`linking actions should create an action to store a linking url 1`] = `
 {
   "meta": undefined,

ts/store/actions/__tests__/linking.test.ts renamed to ts/features/linking/actions/__test__/index.test.ts

@@ -1,9 +1,13 @@
-import { storeLinkingUrl } from "../linking";
+import { clearLinkingUrl, storeLinkingUrl } from "..";
 
 describe("linking actions", () => {
   it("should create an action to store a linking url", () => {
     const url = "https://example.com";
     const action = storeLinkingUrl(url);
     expect(action).toMatchSnapshot();
   });
+  it("should create an action to clear the linking url", () => {
+    const action = clearLinkingUrl();
+    expect(action).toMatchSnapshot();
+  });
 });

ts/features/linking/actions/index.ts

@@ -0,0 +1,9 @@
+import { ActionType, createStandardAction } from "typesafe-actions";
+
+export const storeLinkingUrl =
+  createStandardAction("STORE_LINKING_URL")<string>();
+export const clearLinkingUrl = createStandardAction("CLEAR_LINKING_URL")();
+
+export type BackgroundLinkingActions = ActionType<
+  typeof storeLinkingUrl | typeof clearLinkingUrl
+>;

ts/features/linking/reducers/__test__/index.test.ts

@@ -0,0 +1,50 @@
+import { backgroundLinkingReducer, storedLinkingUrlSelector } from "..";
+import { clearLinkingUrl, storeLinkingUrl } from "../../actions";
+
+describe("background linking reducer", () => {
+  it("should return the initial state", () => {
+    const expected = {};
+    const reducer = backgroundLinkingReducer(undefined, {} as any);
+    expect(reducer).toEqual(expected);
+  });
+
+  it("should handle storing a linking url", () => {
+    const url = "https://example.com";
+    const expected = {
+      linkingUrl: url
+    };
+    const reducer = backgroundLinkingReducer(undefined, storeLinkingUrl(url));
+    expect(reducer).toEqual(expected);
+  });
+  it("should handle clearing the linking url", () => {
+    const url = "https://example.com";
+    const initialState = {
+      linkingUrl: url
+    };
+    const expected = {};
+    const reducer = backgroundLinkingReducer(initialState, clearLinkingUrl());
+    expect(reducer).toEqual(expected);
+  });
+  describe("selectors", () => {
+    ["https://example.com", undefined].forEach(item =>
+      it(`storedlinkingUrlSelector should return ${
+        item === undefined
+          ? "undefined when no link is stored"
+          : "an url that is stored in the reducer"
+      }`, () => {
+        const state = {
+          features: {
+            backgroundLinking:
+              item === undefined
+                ? {}
+                : {
+                    linkingUrl: item
+                  }
+          }
+        } as any;
+        const linkingUrl = storedLinkingUrlSelector(state);
+        expect(linkingUrl).toEqual(item);
+      })
+    );
+  });
+});

ts/store/reducers/linking.ts renamed to ts/features/linking/reducers/index.ts

@@ -1,6 +1,7 @@
 import { getType } from "typesafe-actions";
-import { storeLinkingUrl } from "../actions/linking";
-import { Action } from "../actions/types";
+import { clearLinkingUrl, storeLinkingUrl } from "../actions";
+import { Action } from "../../../store/actions/types";
+import { GlobalState } from "../../../store/reducers/types";
 
 export type BackgroundLinkingState = {
   linkingUrl?: string;
@@ -18,6 +19,11 @@ export const backgroundLinkingReducer = (
         ...state,
         linkingUrl: action.payload
       };
+    case getType(clearLinkingUrl):
+      return INITIAL_STATE;
   }
   return state;
 };
+
+export const storedLinkingUrlSelector = (state: GlobalState) =>
+  state.features.backgroundLinking.linkingUrl;