From f8a556038044effb7c1a3f8c93aaf7c1e5a9fb17 Mon Sep 17 00:00:00 2001 From: Martino Cesari Tomba <60693085+forrest57@users.noreply.github.com> Date: Thu, 25 Jul 2024 14:16:13 +0200 Subject: [PATCH] fix: [IOCOM-1614] Update iOS product name to "IO" from "ItaliaApp" (#6028) ## Short description updated iOS product name in order for system popups to display the correct naming |BEFORE|AFTER| |-|-| || ## List of changes proposed in this pull request updated product naming wherever necessary ## How to test remove both the `Build` and `DerivedData` folders under `ios`, then, while running the dev-server in the FIMS branch, run a fims auth flow and make sure the popup displays the correct product name, as shown in the screenshot. --------- Co-authored-by: Andrea Piai Co-authored-by: Fabio Bombardi <16268789+shadowsheep1@users.noreply.github.com> --- .detoxrc.json | 4 +-- .github/workflows/release.yml | 4 +-- .github/workflows/test-e2e.yml | 8 +++--- ios/.gitignore | 1 + ios/ItaliaApp.xcodeproj/project.pbxproj | 26 +++++++++---------- .../xcshareddata/xcschemes/ItaliaApp.xcscheme | 8 +++--- 6 files changed, 26 insertions(+), 25 deletions(-) diff --git a/.detoxrc.json b/.detoxrc.json index 0780725e792..544e3c2908f 100644 --- a/.detoxrc.json +++ b/.detoxrc.json @@ -4,12 +4,12 @@ "apps": { "ios.release": { "type": "ios.app", - "binaryPath": "ios/build/Build/Products/Release-iphonesimulator/ItaliaApp.app", + "binaryPath": "ios/build/Build/Products/Release-iphonesimulator/IO.app", "build": "xcodebuild -workspace ios/ItaliaApp.xcworkspace -scheme ItaliaApp -configuration Release -sdk iphonesimulator -derivedDataPath ios/build" }, "ios.debug": { "type": "ios.app", - "binaryPath": "ios/build/Build/Products/Debug-iphonesimulator/ItaliaApp.app", + "binaryPath": "ios/build/Build/Products/Debug-iphonesimulator/IO.app", "build": "xcodebuild -workspace ios/ItaliaApp.xcworkspace -scheme ItaliaApp -configuration Debug -sdk iphonesimulator -derivedDataPath ios/build" } }, diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 2496a0798fa..43e94534ab5 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -97,8 +97,8 @@ jobs: continue-on-error: true uses: actions/upload-artifact@26f96dfa697d77e81fd5907df203aa23a56210a8 # v4.0.3 with: - name: ItaliaApp.app.dSYM.zip - path: ios/ItaliaApp.app.dSYM.zip + name: IO.app.dSYM.zip + path: ios/IO.app.dSYM.zip retention-days: 60 notify-new-version: environment: dev diff --git a/.github/workflows/test-e2e.yml b/.github/workflows/test-e2e.yml index 95be94435f2..49bbaed6664 100644 --- a/.github/workflows/test-e2e.yml +++ b/.github/workflows/test-e2e.yml @@ -55,8 +55,8 @@ jobs: - id: upload-detox-build uses: actions/upload-artifact@26f96dfa697d77e81fd5907df203aa23a56210a8 # v4.0.3 with: - name: ItaliaApp.app - path: ios/build/Build/Products/Release-iphonesimulator/ItaliaApp.app + name: IO.app + path: ios/build/Build/Products/Release-iphonesimulator/IO.app retention-days: 2 run-e2e-tests: needs: build-detox-app @@ -87,8 +87,8 @@ jobs: - id: download-detox-build uses: actions/download-artifact@6b208ae046db98c579e8a3aa621ab581ff575935 # v4.1.1 with: - name: ItaliaApp.app - path: ios/build/Build/Products/Release-iphonesimulator/ItaliaApp.app + name: IO.app + path: ios/build/Build/Products/Release-iphonesimulator/IO.app - id: setup uses: ./.github/actions/setup-composite with: diff --git a/ios/.gitignore b/ios/.gitignore index 3d6e05fce6f..6383cceb545 100644 --- a/ios/.gitignore +++ b/ios/.gitignore @@ -1,4 +1,5 @@ ItaliaApp.app* +IO.app* include *.a fastlane/report.xml diff --git a/ios/ItaliaApp.xcodeproj/project.pbxproj b/ios/ItaliaApp.xcodeproj/project.pbxproj index 9f213527512..714c002ca72 100644 --- a/ios/ItaliaApp.xcodeproj/project.pbxproj +++ b/ios/ItaliaApp.xcodeproj/project.pbxproj @@ -70,25 +70,25 @@ 00E356EE1AD99517003FC87E /* ItaliaAppTests.xctest */ = {isa = PBXFileReference; explicitFileType = wrapper.cfbundle; includeInIndex = 0; path = ItaliaAppTests.xctest; sourceTree = BUILT_PRODUCTS_DIR; }; 00E356F11AD99517003FC87E /* Info.plist */ = {isa = PBXFileReference; lastKnownFileType = text.plist.xml; path = Info.plist; sourceTree = ""; }; 00E356F21AD99517003FC87E /* ItaliaAppTests.m */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.objc; path = ItaliaAppTests.m; sourceTree = ""; }; - 015E4FBE7D1D4C2485C73321 /* TitilliumSansPro-SemiboldItalic.otf */ = {isa = PBXFileReference; explicitFileType = undefined; fileEncoding = undefined; includeInIndex = 0; lastKnownFileType = unknown; name = "TitilliumSansPro-SemiboldItalic.otf"; path = "../assets/fonts/TitilliumSansPro/TitilliumSansPro-SemiboldItalic.otf"; sourceTree = ""; }; + 015E4FBE7D1D4C2485C73321 /* TitilliumSansPro-SemiboldItalic.otf */ = {isa = PBXFileReference; explicitFileType = undefined; fileEncoding = 9; includeInIndex = 0; lastKnownFileType = unknown; name = "TitilliumSansPro-SemiboldItalic.otf"; path = "../assets/fonts/TitilliumSansPro/TitilliumSansPro-SemiboldItalic.otf"; sourceTree = ""; }; 058F4F4927B1B1C84C7F1137 /* Pods-ItaliaApp-ItaliaAppTests.release.xcconfig */ = {isa = PBXFileReference; includeInIndex = 1; lastKnownFileType = text.xcconfig; name = "Pods-ItaliaApp-ItaliaAppTests.release.xcconfig"; path = "Target Support Files/Pods-ItaliaApp-ItaliaAppTests/Pods-ItaliaApp-ItaliaAppTests.release.xcconfig"; sourceTree = ""; }; - 132CADD7BDBB46C7AB1DC348 /* TitilliumSansPro-BlackItalic.otf */ = {isa = PBXFileReference; explicitFileType = undefined; fileEncoding = undefined; includeInIndex = 0; lastKnownFileType = unknown; name = "TitilliumSansPro-BlackItalic.otf"; path = "../assets/fonts/TitilliumSansPro/TitilliumSansPro-BlackItalic.otf"; sourceTree = ""; }; + 132CADD7BDBB46C7AB1DC348 /* TitilliumSansPro-BlackItalic.otf */ = {isa = PBXFileReference; explicitFileType = undefined; fileEncoding = 9; includeInIndex = 0; lastKnownFileType = unknown; name = "TitilliumSansPro-BlackItalic.otf"; path = "../assets/fonts/TitilliumSansPro/TitilliumSansPro-BlackItalic.otf"; sourceTree = ""; }; 133638FB213D788900B0C079 /* en */ = {isa = PBXFileReference; lastKnownFileType = text.plist.strings; name = en; path = en.lproj/InfoPlist.strings; sourceTree = ""; }; 133638FD213D78DB00B0C079 /* it */ = {isa = PBXFileReference; lastKnownFileType = text.plist.strings; name = it; path = it.lproj/InfoPlist.strings; sourceTree = ""; }; - 13B07F961A680F5B00A75B9A /* ItaliaApp.app */ = {isa = PBXFileReference; explicitFileType = wrapper.application; includeInIndex = 0; path = ItaliaApp.app; sourceTree = BUILT_PRODUCTS_DIR; }; + 13B07F961A680F5B00A75B9A /* IO.app */ = {isa = PBXFileReference; explicitFileType = wrapper.application; includeInIndex = 0; path = IO.app; sourceTree = BUILT_PRODUCTS_DIR; }; 13B07FAF1A68108700A75B9A /* AppDelegate.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = AppDelegate.h; path = ItaliaApp/AppDelegate.h; sourceTree = ""; }; 13B07FB01A68108700A75B9A /* AppDelegate.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; name = AppDelegate.mm; path = ItaliaApp/AppDelegate.mm; sourceTree = ""; }; 13B07FB51A68108700A75B9A /* Images.xcassets */ = {isa = PBXFileReference; lastKnownFileType = folder.assetcatalog; name = Images.xcassets; path = ItaliaApp/Images.xcassets; sourceTree = ""; }; 13B07FB61A68108700A75B9A /* Info.plist */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text.plist.xml; name = Info.plist; path = ItaliaApp/Info.plist; sourceTree = ""; }; 13B07FB71A68108700A75B9A /* main.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; name = main.m; path = ItaliaApp/main.m; sourceTree = ""; }; - 148E8F80A1D5448DAD5263B7 /* TitilliumSansPro-Italic.otf */ = {isa = PBXFileReference; explicitFileType = undefined; fileEncoding = undefined; includeInIndex = 0; lastKnownFileType = unknown; name = "TitilliumSansPro-Italic.otf"; path = "../assets/fonts/TitilliumSansPro/TitilliumSansPro-Italic.otf"; sourceTree = ""; }; + 148E8F80A1D5448DAD5263B7 /* TitilliumSansPro-Italic.otf */ = {isa = PBXFileReference; explicitFileType = undefined; fileEncoding = 9; includeInIndex = 0; lastKnownFileType = unknown; name = "TitilliumSansPro-Italic.otf"; path = "../assets/fonts/TitilliumSansPro/TitilliumSansPro-Italic.otf"; sourceTree = ""; }; 194A5D2A1F027F5A0078620E /* Podfile */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text; path = Podfile; sourceTree = ""; xcLanguageSpecificationIdentifier = xcode.lang.ruby; }; 2A1DC2C4323E417BBBAE8817 /* RobotoMono-BoldItalic.ttf */ = {isa = PBXFileReference; explicitFileType = undefined; fileEncoding = 9; includeInIndex = 0; lastKnownFileType = unknown; name = "RobotoMono-BoldItalic.ttf"; path = "../assets/fonts/RobotoMono/RobotoMono-BoldItalic.ttf"; sourceTree = ""; }; 2AD40B9824CB049500E4124A /* LaunchScreen.storyboard */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = file.storyboard; name = LaunchScreen.storyboard; path = ItaliaApp/LaunchScreen.storyboard; sourceTree = ""; }; 2AFAC65324C9B7C300E85199 /* ItaliaApp-Bridging-Header.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = "ItaliaApp-Bridging-Header.h"; sourceTree = ""; }; 2C584AD92CB24628B1AA76DE /* ReadexPro-Regular.ttf */ = {isa = PBXFileReference; explicitFileType = undefined; fileEncoding = 9; includeInIndex = 0; lastKnownFileType = unknown; name = "ReadexPro-Regular.ttf"; path = "../assets/fonts/ReadexPro/ReadexPro-Regular.ttf"; sourceTree = ""; }; 2D52800996AA471A87A7F975 /* LICENSE.txt */ = {isa = PBXFileReference; explicitFileType = undefined; fileEncoding = 9; includeInIndex = 0; lastKnownFileType = unknown; name = LICENSE.txt; path = ../assets/fonts/RobotoMono/LICENSE.txt; sourceTree = ""; }; - 3CA5B0F4CFD44E78900FE43A /* TitilliumSansPro-LightItalic.otf */ = {isa = PBXFileReference; explicitFileType = undefined; fileEncoding = undefined; includeInIndex = 0; lastKnownFileType = unknown; name = "TitilliumSansPro-LightItalic.otf"; path = "../assets/fonts/TitilliumSansPro/TitilliumSansPro-LightItalic.otf"; sourceTree = ""; }; + 3CA5B0F4CFD44E78900FE43A /* TitilliumSansPro-LightItalic.otf */ = {isa = PBXFileReference; explicitFileType = undefined; fileEncoding = 9; includeInIndex = 0; lastKnownFileType = unknown; name = "TitilliumSansPro-LightItalic.otf"; path = "../assets/fonts/TitilliumSansPro/TitilliumSansPro-LightItalic.otf"; sourceTree = ""; }; 5389C36762A04AE69D762289 /* RobotoMono-RegularItalic.ttf */ = {isa = PBXFileReference; explicitFileType = undefined; fileEncoding = 9; includeInIndex = 0; lastKnownFileType = unknown; name = "RobotoMono-RegularItalic.ttf"; path = "../assets/fonts/RobotoMono/RobotoMono-RegularItalic.ttf"; sourceTree = ""; }; 59BCC34321A36ABA56F255E3 /* libPods-ItaliaApp-ItaliaAppTests.a */ = {isa = PBXFileReference; explicitFileType = archive.ar; includeInIndex = 0; path = "libPods-ItaliaApp-ItaliaAppTests.a"; sourceTree = BUILT_PRODUCTS_DIR; }; 640E574519CA4183B230AF22 /* RobotoMono-LightItalic.ttf */ = {isa = PBXFileReference; explicitFileType = undefined; fileEncoding = 9; includeInIndex = 0; lastKnownFileType = unknown; name = "RobotoMono-LightItalic.ttf"; path = "../assets/fonts/RobotoMono/RobotoMono-LightItalic.ttf"; sourceTree = ""; }; @@ -98,7 +98,7 @@ 722056DF161D843DD91D88A7 /* Pods-ItaliaApp.debug.xcconfig */ = {isa = PBXFileReference; includeInIndex = 1; lastKnownFileType = text.xcconfig; name = "Pods-ItaliaApp.debug.xcconfig"; path = "Target Support Files/Pods-ItaliaApp/Pods-ItaliaApp.debug.xcconfig"; sourceTree = ""; }; 76E4CEA78E3F4060ABB59808 /* RobotoMono-Regular.ttf */ = {isa = PBXFileReference; explicitFileType = undefined; fileEncoding = 9; includeInIndex = 0; lastKnownFileType = unknown; name = "RobotoMono-Regular.ttf"; path = "../assets/fonts/RobotoMono/RobotoMono-Regular.ttf"; sourceTree = ""; }; 7A83F0572152B12C000C6389 /* ItaliaApp.entitlements */ = {isa = PBXFileReference; lastKnownFileType = text.plist.entitlements; name = ItaliaApp.entitlements; path = ItaliaApp/ItaliaApp.entitlements; sourceTree = ""; }; - 872A6A79E0CF4C4DA0AEAF3E /* TitilliumSansPro-BoldItalic.otf */ = {isa = PBXFileReference; explicitFileType = undefined; fileEncoding = undefined; includeInIndex = 0; lastKnownFileType = unknown; name = "TitilliumSansPro-BoldItalic.otf"; path = "../assets/fonts/TitilliumSansPro/TitilliumSansPro-BoldItalic.otf"; sourceTree = ""; }; + 872A6A79E0CF4C4DA0AEAF3E /* TitilliumSansPro-BoldItalic.otf */ = {isa = PBXFileReference; explicitFileType = undefined; fileEncoding = 9; includeInIndex = 0; lastKnownFileType = unknown; name = "TitilliumSansPro-BoldItalic.otf"; path = "../assets/fonts/TitilliumSansPro/TitilliumSansPro-BoldItalic.otf"; sourceTree = ""; }; 875B0C3A5326413494A9311A /* DMMono-Medium.ttf */ = {isa = PBXFileReference; explicitFileType = undefined; fileEncoding = 9; includeInIndex = 0; lastKnownFileType = unknown; name = "DMMono-Medium.ttf"; path = "../assets/fonts/DMMono/DMMono-Medium.ttf"; sourceTree = ""; }; A88AAE92C2AA92D33DB25F0C /* libPods-ItaliaApp.a */ = {isa = PBXFileReference; explicitFileType = archive.ar; includeInIndex = 0; path = "libPods-ItaliaApp.a"; sourceTree = BUILT_PRODUCTS_DIR; }; AFE8D23873DE458BB54EB46B /* RobotoMono-Light.ttf */ = {isa = PBXFileReference; explicitFileType = undefined; fileEncoding = 9; includeInIndex = 0; lastKnownFileType = unknown; name = "RobotoMono-Light.ttf"; path = "../assets/fonts/RobotoMono/RobotoMono-Light.ttf"; sourceTree = ""; }; @@ -117,7 +117,7 @@ F2B1630A2B753C9D00F6E487 /* TitilliumSansPro-Regular.otf */ = {isa = PBXFileReference; lastKnownFileType = file; name = "TitilliumSansPro-Regular.otf"; path = "../assets/fonts/TitilliumSansPro/TitilliumSansPro-Regular.otf"; sourceTree = ""; }; F2B1630C2B753C9D00F6E487 /* TitilliumSansPro-Bold.otf */ = {isa = PBXFileReference; lastKnownFileType = file; name = "TitilliumSansPro-Bold.otf"; path = "../assets/fonts/TitilliumSansPro/TitilliumSansPro-Bold.otf"; sourceTree = ""; }; F6095D182BC6E01F000EA253 /* PrivacyInfo.xcprivacy */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text.xml; name = PrivacyInfo.xcprivacy; path = ItaliaApp/PrivacyInfo.xcprivacy; sourceTree = ""; }; - F820513E31C7443CB7F5A99E /* TitilliumSansPro-ThinItalic.otf */ = {isa = PBXFileReference; explicitFileType = undefined; fileEncoding = undefined; includeInIndex = 0; lastKnownFileType = unknown; name = "TitilliumSansPro-ThinItalic.otf"; path = "../assets/fonts/TitilliumSansPro/TitilliumSansPro-ThinItalic.otf"; sourceTree = ""; }; + F820513E31C7443CB7F5A99E /* TitilliumSansPro-ThinItalic.otf */ = {isa = PBXFileReference; explicitFileType = undefined; fileEncoding = 9; includeInIndex = 0; lastKnownFileType = unknown; name = "TitilliumSansPro-ThinItalic.otf"; path = "../assets/fonts/TitilliumSansPro/TitilliumSansPro-ThinItalic.otf"; sourceTree = ""; }; /* End PBXFileReference section */ /* Begin PBXFrameworksBuildPhase section */ @@ -252,7 +252,7 @@ 83CBBA001A601CBA00E9B192 /* Products */ = { isa = PBXGroup; children = ( - 13B07F961A680F5B00A75B9A /* ItaliaApp.app */, + 13B07F961A680F5B00A75B9A /* IO.app */, 00E356EE1AD99517003FC87E /* ItaliaAppTests.xctest */, ); name = Products; @@ -315,7 +315,7 @@ ); name = ItaliaApp; productName = "Hello World"; - productReference = 13B07F961A680F5B00A75B9A /* ItaliaApp.app */; + productReference = 13B07F961A680F5B00A75B9A /* IO.app */; productType = "com.apple.product-type.application"; }; /* End PBXNativeTarget section */ @@ -712,7 +712,7 @@ ); PRODUCT_BUNDLE_IDENTIFIER = "it.teamdigitale.app.$(PRODUCT_NAME:rfc1034identifier)"; PRODUCT_NAME = "$(TARGET_NAME)"; - TEST_HOST = "$(BUILT_PRODUCTS_DIR)/ItaliaApp.app/ItaliaApp"; + TEST_HOST = "$(BUILT_PRODUCTS_DIR)/IO.app/IO"; }; name = Debug; }; @@ -734,7 +734,7 @@ ); PRODUCT_BUNDLE_IDENTIFIER = "it.teamdigitale.app.$(PRODUCT_NAME:rfc1034identifier)"; PRODUCT_NAME = "$(TARGET_NAME)"; - TEST_HOST = "$(BUILT_PRODUCTS_DIR)/ItaliaApp.app/ItaliaApp"; + TEST_HOST = "$(BUILT_PRODUCTS_DIR)/IO.app/IO"; }; name = Release; }; @@ -769,7 +769,7 @@ "-lc++", ); PRODUCT_BUNDLE_IDENTIFIER = it.pagopa.app.io; - PRODUCT_NAME = ItaliaApp; + PRODUCT_NAME = IO; PROVISIONING_PROFILE = "0848c226-68ec-4314-ad27-50803db95257"; PROVISIONING_PROFILE_SPECIFIER = "match Development it.pagopa.app.io"; SWIFT_OBJC_BRIDGING_HEADER = "ItaliaApp-Bridging-Header.h"; @@ -810,7 +810,7 @@ "-lc++", ); PRODUCT_BUNDLE_IDENTIFIER = it.pagopa.app.io; - PRODUCT_NAME = ItaliaApp; + PRODUCT_NAME = IO; PROVISIONING_PROFILE = "0848c226-68ec-4314-ad27-50803db95257"; PROVISIONING_PROFILE_SPECIFIER = "match AppStore it.pagopa.app.io"; SWIFT_OBJC_BRIDGING_HEADER = "ItaliaApp-Bridging-Header.h"; diff --git a/ios/ItaliaApp.xcodeproj/xcshareddata/xcschemes/ItaliaApp.xcscheme b/ios/ItaliaApp.xcodeproj/xcshareddata/xcschemes/ItaliaApp.xcscheme index 5f914566887..15cbff04118 100644 --- a/ios/ItaliaApp.xcodeproj/xcshareddata/xcschemes/ItaliaApp.xcscheme +++ b/ios/ItaliaApp.xcodeproj/xcshareddata/xcschemes/ItaliaApp.xcscheme @@ -29,7 +29,7 @@ @@ -59,7 +59,7 @@ @@ -92,7 +92,7 @@ @@ -109,7 +109,7 @@