Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error messages on failed oauth call #69

Open
pajlada opened this issue Oct 5, 2019 · 1 comment
Open

Better error messages on failed oauth call #69

pajlada opened this issue Oct 5, 2019 · 1 comment

Comments

@pajlada
Copy link
Member

pajlada commented Oct 5, 2019

we should print whether or not the error was caused by bad redirect uri or not

@RAnders00
Copy link
Contributor

RAnders00 commented Oct 25, 2019

On error, the user is sent to <REDIRECT_URI>?error=error_code&error_description=A+readable+description

Note for correctness: The OAuth standard only mandates the ?error=error_code parameter to be present, and Twitch doesn't specify anywhere that they send error_description all the time. We should display the error description if it's present, but should gracefully handle the case when it's not present. https://tools.ietf.org/html/rfc6749#section-4.1.2.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants