Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always send uniques #130

Closed
zeroquinc opened this issue Jan 17, 2023 · 5 comments
Closed

Always send uniques #130

zeroquinc opened this issue Jan 17, 2023 · 5 comments
Labels
New setting Suggestion for a new setting/configuration/option Notifier: Loot

Comments

@zeroquinc
Copy link

First of all thanks very much for the embed commit, my notifications look so much cleaner now!

A feature I still would like to see added is an option under Loot; Always send uniques.

The way it works now is that the collection log notification will still pop but if you already have gotten it once it obviously won't.

Could this be a new toggle? Thank you it's very nice to see active development on this!

@Felanbird Felanbird added Notifier: Loot New setting Suggestion for a new setting/configuration/option labels Jan 17, 2023
@Felanbird
Copy link
Member

My immediate question is how do we go about checking what is a unique?
From what I can see discord-rare-drop-notifier has their own list but taking that approach would be no fun. https://github.com/BossHuso/discord-rare-drop-notificater/blob/master/src/main/java/com/masterkenth/EventRarity.java

Hopefully there's some API that we could use to figure this out 🤔

@pajlada
Copy link
Member

pajlada commented Jan 20, 2023

By unique, do you mean every item in the collection log? So if this setting is on, you'd send a loot notification every time you loot a:

  • Vorkath's head from Vorkath
  • Soaked pages from Tempoross
  • Ancient Shard from any monster in Catacombs of Kourend
  • Ancient essence from Phantom Muspah
  • Iasor/Kronos/Attas seed from Hespori
  • Granite dust from Grotesque Guardians
  • Mole skin or Mole claw from Giant Mole
  • Bolt rack from Barrows

The reason I'm asking is if the above is undesirable, maybe there's another way we can identify items you want to send notifications for instead

@zeroquinc
Copy link
Author

Yeah, that is kinda what I meant. And then for example that you can set a minimum value and drop rate.

For example I don't want to have every Mole claw as notification but if I could set the value rarity to have a minimum of 1/256 it would still give me notifications for rare drops that maybe cost less than what I have set up under "Loot" as Min Loot Value.

@pajlada
Copy link
Member

pajlada commented Jan 21, 2023

Do you think your recent suggestion of #139 would cover this use-case effectively?

@zeroquinc
Copy link
Author

Do you think your recent suggestion of #139 would cover this use-case effectively?

Yeah, I think it does. Maybe it's better to close this and continue in that topic.

@iProdigy iProdigy closed this as not planned Won't fix, can't repro, duplicate, stale Jan 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New setting Suggestion for a new setting/configuration/option Notifier: Loot
Projects
None yet
Development

No branches or pull requests

4 participants