Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kill count for new collection log entries #371

Closed
2 tasks done
TomBolks opened this issue Nov 25, 2023 · 3 comments · Fixed by #424
Closed
2 tasks done

Kill count for new collection log entries #371

TomBolks opened this issue Nov 25, 2023 · 3 comments · Fixed by #424
Assignees
Labels
enhancement Improvement to an already existing notifier Notifier: Collection Log

Comments

@TomBolks
Copy link
Contributor

Checklist

  • I've searched the issues and pull requests for similar looking suggestions.
  • I've checked the Unreleased section of the changelog for newly added features that sound like my suggestion.

Describe your Suggestion

If available and possible add the kill count and monster that dropped the new collection log entry.

Reasoning

It would be nice to see the information since some items can be dropped by multiple bosses and to see if someone is getting spooned

@TomBolks TomBolks added the enhancement Improvement to an already existing notifier label Nov 25, 2023
@iProdigy iProdigy self-assigned this Nov 25, 2023
@iProdigy iProdigy removed their assignment Dec 13, 2023
@iProdigy
Copy link
Member

iProdigy commented Dec 13, 2023

Actually this is tricky since the collection event has no idea of the source of the item. Accordingly, we probably need to store the loot table of every NPC, which is blocked like #139 due to incomplete data scraping described in #141 (comment)

@iProdigy iProdigy added the blocked Something out of our power needs to change before proceeding with this issue label Dec 13, 2023
@iProdigy
Copy link
Member

iProdigy commented Dec 13, 2023

Relevant edge cases:

  • clue casket opened at same time as npc kill
  • random event reward received at same time
  • multiple collection item drops at once, but user has collection popup enabled (increases time since kill)
  • barrows chest count
  • tempoross
  • wintertodt
  • cox
  • toa
  • tob
  • etc.

@iProdigy
Copy link
Member

iProdigy commented Dec 13, 2023

Probably good enough: if npc killed within same second of collection notif & no clue casket opened in that period, attribute item to npc

edit: actually we can use the resolved item id of the collection log & match with the itemstack contents of the most recent loot event

@iProdigy iProdigy removed the blocked Something out of our power needs to change before proceeding with this issue label Dec 13, 2023
@iProdigy iProdigy self-assigned this Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement to an already existing notifier Notifier: Collection Log
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants