Report button inconsistency

[emiljensen2]

Checklist

• I'm reporting a problem with Dink
• I've searched the issues and pull requests for similar looking reports

Describe your issue

When dink takes a screenshot of events it doesn't always show the date despite it being enabled in the base screenshot plugin.
I'm not quite sure what causes it
Collection log events seem to always have the date show if popup is enabled, I see some cases of date not showing and they don't have the popup enabled.
CA events also seem to capture date consistently (Though this is without the popup, so unsure if it's always true)
Levels, loot, kill count, quests is inconsistent from what I've seen.

Sorry for yet another report

Screenshots

Runelite Logs

shouldn't be relevant

Runelite Version

1.10.19

[pajlada]

Could you compare these with the screenshots that were saved on disk (and maybe post them too)?

[emiljensen2]

I've taken some levels screenshots since my rl doesn't do loot itself.




The mining screenshot is interesting, they appear to be taken a little time apart as my idle notification is visible on the dink screenshot, but not the local screenshot.
Though ig it's also visibly different for the zeah screenshot.

[pajlada]

We delay certain notifiers, sometimes to make sure we get all level ups that happened, sometimes to give time for the loot to appear in the chat or on the ground for the screenshot.

I suspect this is just a matter of us not using the screenshot plugin, but just happen to be taking screenshots at the same time as the screenshot plugin for certain events.

I guess it boils down to more of a feature request: Should we replicate the screenshot plugin's "Report button" functionality?

[emiljensen2]

Ah that makes sense, I thought at first you were using the screenshot plugin's functionality so to speak. but that makes sense.
So it's inconsistent because it sometimes captures on the same frame/tick(?), but it is not intended.

Yeah I guess it'd be a feature request then.

[iProdigy]

Yeah we would have to replicate https://github.com/runelite/runelite/blob/master/runelite-client/src/main/java/net/runelite/client/plugins/screenshot/ScreenshotOverlay.java to implement this feature

[Felanbird]

The current upstream implementation of the report button does not respect where the report button actually is, if the chat box is somewhere else, it will just float in it's normal spot. Keep that in mind whether or not we want to fix it ourselves, fix it for them, or wait for someone to fix it.

Discussed in the discord last week but I don't believe anyone bothered to open an issue.