With this setting enabled, would it be reasonable to have to allowlist certain rare untradeable drops that may have a store value below the configured value threshold?

The current allowlist notifies on items regardless of value already right? So I would imagine it would work the same way with this.

The way I am imagining this would work is when the notifier checks the value is higher than the threshold, it would then just do an additional check against the rarity threshold before sending the message

Could it be as simple as something like this?

This is very rough and inefficient and I'm not familiar with this code, so I could be way off, just an idea

With this setting enabled, would it be reasonable to have to allowlist certain rare untradeable drops that may have a store value below the configured value threshold?

hmm, I guess this may just be a limitation of using this option. Unless there is some way to identify untradeables, and some other setting associated with that

Could it be as simple as something like this?

unfortunately it's a bit more complicated (as you can see in the PR)

hmm, I guess this may just be a limitation of using this option. Unless there is some way to identify untradeables, and some other setting associated with that

we theoretically could identify items that are not traded on the GE, but I want to avoid settings proliferation (and the code is complicated enough without that customization)

in general, there are likely more rare untradeable items with low store value that shouldn't be dinked (relative to those that should), so the allowlist approach should be fine

yeah sounds sensible, thanks for taking a look at this!