Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change config using login name to account hash. #17

Open
umer-rs opened this issue Feb 16, 2024 · 1 comment
Open

change config using login name to account hash. #17

umer-rs opened this issue Feb 16, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@umer-rs
Copy link

umer-rs commented Feb 16, 2024

final String stateGroup = StealingArtefactsConfig.GROUP_NAME + "." + client.getUsername();

Change using the login name in the config group to the account hash. This would mirror how Runelite does it, and might help with account security for people who import/export their settings.

Also getUsername seems to be deprecated.

https://github.com/runelite/runelite/blob/f86b2b1bc75ee927a6971354ff2609e2de32555a/runelite-api/src/main/java/com/jagex/oldscape/pub/OAuthApi.java

@pajlada
Copy link
Member

pajlada commented Feb 16, 2024

👍 should be easy & non-disruptive

Would be fixed by #5 but it's not quite ready

@pajlada pajlada added the enhancement New feature or request label Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants