Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When using jlink, we can't use --add-modules ALL-MODULE-PATH #350

Open
cmdjulian opened this issue Dec 11, 2022 · 1 comment
Open

When using jlink, we can't use --add-modules ALL-MODULE-PATH #350

cmdjulian opened this issue Dec 11, 2022 · 1 comment
Labels
hacktoberfest Hacktoberfest eligible note:good-first-issue A good first issue to get started with note:ideal-for-contribution An issue that a contributor can help us with type:bug A general bug

Comments

@cmdjulian
Copy link

When using --add-modules ALL-MODULE-PATH as jlink arg to add all modules to the jre, the build fails with: Error: Module all-module-path not found. Note the lowercase here

Expected Behavior

Build should work

Possible Solution

Maybe there is some toLowerCase() call?

Steps to Reproduce

  1. add BP_JVM_JLINK_ENABLED: true
  2. add BP_JVM_JLINK_ARGS: --add-modules ALL-MODULE-PATH --compress=2 --no-header-files --no-man-pages --strip-debug

Motivations

We wanna test and get a feeling for jlink. Currently our application is not modulrized, so we wanna start by trimming the modules from all modules. It also is mentioned in jlink help section to use that shortcut:

image

@dmikusa
Copy link
Contributor

dmikusa commented Dec 12, 2022

Thanks for the report. It looks like this is happening during the argument validation. I guess we'll need a bit of additional logic there to ensure we're not squashing the case on the module names.

@dmikusa dmikusa added type:bug A general bug note:good-first-issue A good first issue to get started with note:ideal-for-contribution An issue that a contributor can help us with labels Dec 12, 2022
@anthonydahanne anthonydahanne added the hacktoberfest Hacktoberfest eligible label Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest Hacktoberfest eligible note:good-first-issue A good first issue to get started with note:ideal-for-contribution An issue that a contributor can help us with type:bug A general bug
Projects
None yet
Development

No branches or pull requests

3 participants