Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Allow single day range" not respected if using end time picker before selecting date #6856

Open
evansjohnson opened this issue Jun 24, 2024 · 0 comments · May be fixed by #6858
Open

"Allow single day range" not respected if using end time picker before selecting date #6856

evansjohnson opened this issue Jun 24, 2024 · 0 comments · May be fixed by #6858

Comments

@evansjohnson
Copy link
Contributor

evansjohnson commented Jun 24, 2024

Screenshot 2024-06-24 at 8 30 34 AM

Steps to reproduce

When fixing https://github.com/palantir/blueprint/issues/6483 this will likely become the behavior for any date, not just selecting today's date, since using the selected start date as a default for the end date when selecting a time is likely more applicable.

Actual behavior

If selecting today's date, modifying the time of the end date causes the date range to be a single day, even if the allowSingleDayRange prop is true.

Expected behavior

Should not be able to select an end date equal to the start date when allowSingleDayRange is not true.

Possible solution

Add one day to the default value when allowSingleDayRange is not true.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant