Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow *.ir.json as alternative IR filename #253

Open
gatesn opened this issue Oct 3, 2019 · 0 comments
Open

Allow *.ir.json as alternative IR filename #253

gatesn opened this issue Oct 3, 2019 · 0 comments

Comments

@gatesn
Copy link

gatesn commented Oct 3, 2019

This line is strict for *.conjure.json: https://github.com/palantir/gradle-conjure/blob/develop/gradle-conjure/src/main/java/com/palantir/gradle/conjure/ConjureLocalGenerateGenericTask.java#L30

But the Conjure Godel plugin generates *.ir.json files making them unusable: https://github.com/palantir/godel-conjure-plugin/blob/96bccdf6c9de1eec90a94a601a677b0bd2182d39/conjureplugin/publish.go#L65

It may be easier to relax this plugin so it works against all previously published IR files even if we go on to fix the godel plugin too.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gatesn