Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use extras to define packaging options and their dependencies #2452

Closed
samuelhwilliams opened this issue Jul 15, 2024 · 0 comments · Fixed by #2476
Closed

Use extras to define packaging options and their dependencies #2452

samuelhwilliams opened this issue Jul 15, 2024 · 0 comments · Fixed by #2476

Comments

@samuelhwilliams
Copy link
Contributor

samuelhwilliams commented Jul 15, 2024 •
edited

At the moment we don't cleanly define what the package version requirements are for the optional dependencies (sqlalchemy, mongoengine, etc).

We could make these installable for package extras (eg pip install flask-admin[sqlalchemy]) and then have clearer versioning constraints to

  • help users understand what is/isn't supported.
  • make it easier/simpler to install flask-admin and have it work
  • clear up what testing variants we might need (eg for major versions of dependencies)
@samuelhwilliams samuelhwilliams mentioned this issue Jul 24, 2024
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Dependencies via pip extras pallets-eco/flask-admin
1 participant
@samuelhwilliams