Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Merge NetworkDetails, WalletChain, ChainName, ChainMetadata objects #70

Open
esteblock opened this issue Nov 13, 2023 · 3 comments

Comments

@esteblock
Copy link
Member

esteblock commented Nov 13, 2023

There is reduntant information in these objects
https://github.com/paltalabs/soroban-react/blob/main/packages/types/src/index.tsx

@esteblock esteblock changed the title Clean NetworkDetails, WalletChain, ChainName, ChainMetadata Refactor: Merge NetworkDetails, WalletChain, ChainName, ChainMetadata objects Jul 30, 2024
@esteblock
Copy link
Member Author

esteblock commented Jul 30, 2024

/packages/types/src/index.tsx

export type ChainName =
  | 'futurenet'
  | 'public'
  | 'testnet'
  | 'sandbox'
  | 'standalone'

export type ChainMetadata = WalletChain

@esteblock
Copy link
Member Author

esteblock commented Jul 30, 2024

packages/types/src/index.tsx

export interface NetworkDetails {
  network: string
  networkUrl: string
  networkPassphrase: string
  sorobanRpcUrl?: string
}

export interface WalletChain {
  id: string
  name?: string
  networkPassphrase: string
  iconBackground?: string
  iconUrl?: string | null
  unsupported?: boolean
  network: string
  networkUrl: string
  sorobanRpcUrl?: string
}

@ShantelPeters
Copy link

@esteblock please can I be assigned to this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants