From 6cfcb2a34ae42c18446d5ad0b43b26ea61f79496 Mon Sep 17 00:00:00 2001 From: Shawn Reuland Date: Tue, 30 May 2023 16:34:45 -0700 Subject: [PATCH 1/2] use non buffer format of fromXDR --- packages/contracts/src/useContractValue.tsx | 2 +- packages/core/package.json | 4 ++-- packages/events/README.md | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/packages/contracts/src/useContractValue.tsx b/packages/contracts/src/useContractValue.tsx index 3e6c331..d5fc8ce 100644 --- a/packages/contracts/src/useContractValue.tsx +++ b/packages/contracts/src/useContractValue.tsx @@ -118,5 +118,5 @@ async function fetchContractValue({ throw new Error("Invalid response from simulateTransaction"); } const result = results[0]; - return xdr.ScVal.fromXDR(Buffer.from(result.xdr, 'base64')); + return xdr.ScVal.fromXDR(result.xdr, "base64"); } diff --git a/packages/core/package.json b/packages/core/package.json index 697a02a..39fea81 100644 --- a/packages/core/package.json +++ b/packages/core/package.json @@ -19,10 +19,10 @@ "version": "4.5.2", "scripts": { "prebuild": "rm -rf dist", - "build": "tsc", + "build": "yarn prebuild && tsc", "start": "tsc --watch", "prepare": "install-peers", - "test": "yarn build && yarn jest" + "test": "yarn prepare && yarn build && yarn jest" }, "main": "./dist/index.js", "exports": "./dist/index.js", diff --git a/packages/events/README.md b/packages/events/README.md index 7906379..6b70111 100644 --- a/packages/events/README.md +++ b/packages/events/README.md @@ -10,7 +10,7 @@ const crowdfundPledgedEventSubscription: EventSubscription = { contractId: Constants.CrowdfundId, topics: ['pledged_amount_changed'], cb: (event: SorobanClient.SorobanRpc.EventResponse): void => { - let eventTokenBalance = xdr.ScVal.fromXDR(Buffer.from(event.value.xdr, 'base64')) + let eventTokenBalance = xdr.ScVal.fromXDR(event.value.xdr, "base64") setTokenBalance(convert.scvalToBigNumber(eventTokenBalance)) }, id: Math.random()} From 7cf032abcdf29d0e4ec7e1d975fc6f100f7e7e3b Mon Sep 17 00:00:00 2001 From: Shawn Reuland Date: Wed, 31 May 2023 12:27:03 -0700 Subject: [PATCH 2/2] review feedback --- packages/events/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/events/README.md b/packages/events/README.md index 6b70111..cbadad3 100644 --- a/packages/events/README.md +++ b/packages/events/README.md @@ -10,7 +10,7 @@ const crowdfundPledgedEventSubscription: EventSubscription = { contractId: Constants.CrowdfundId, topics: ['pledged_amount_changed'], cb: (event: SorobanClient.SorobanRpc.EventResponse): void => { - let eventTokenBalance = xdr.ScVal.fromXDR(event.value.xdr, "base64") + let eventTokenBalance = xdr.ScVal.fromXDR(event.value.xdr, 'base64') setTokenBalance(convert.scvalToBigNumber(eventTokenBalance)) }, id: Math.random()}