From 12a43565addfdf720b3ba8cc45eab6daf66f85dd Mon Sep 17 00:00:00 2001 From: "Maciej W. Rozycki" Date: Mon, 12 Feb 2018 16:04:05 +0000 Subject: [PATCH] MIPS/GAS/test: Fix an n32 `.reginfo' size test failure Correct a commit 2d6dda71611b ("MIPS/BFD: Correctly report unsupported `.reginfo' section size") issue and avoid a GAS test failure: regexp_diff match failure regexp "^.*: Incorrect `\.reginfo' section size; expected 24, got 28$" line "../as-new: dump.o: Incorrect `.reginfo' section size; expected 24, got 32" FAIL: MIPS assembled .reginfo section size (n32) on MIPS targets other than bare-metal ones. The reason for this failure is section padding to alignment, done in `size_seg'. For n32 `.reginfo' the section alignment is set to 3, and therefore the section is padded to a multiple of 8, except for bare-metal targets, for which padding is unconditionally disabled in `md_section_align'. Use `--no-pad-sections' then to disable padding for all targets, so that the size of `.reginfo' is always the same, matching the message pattern. gas/ * testsuite/gas/mips/reginfo-2-n32.d: Add `--no-pad-sections' to `as' flags. --- gas/ChangeLog | 5 +++++ gas/testsuite/gas/mips/reginfo-2-n32.d | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/gas/ChangeLog b/gas/ChangeLog index dfb5edf6229..5c8ffd1b9ba 100644 --- a/gas/ChangeLog +++ b/gas/ChangeLog @@ -1,3 +1,8 @@ +2018-02-12 Maciej W. Rozycki + + * testsuite/gas/mips/reginfo-2-n32.d: Add `--no-pad-sections' to + `as' flags. + 2018-02-12 Henry Wong * testsuite/gas/mips/r6.d: Update for "sigrie" encoding fix. diff --git a/gas/testsuite/gas/mips/reginfo-2-n32.d b/gas/testsuite/gas/mips/reginfo-2-n32.d index ec1f9e32182..572c076b495 100644 --- a/gas/testsuite/gas/mips/reginfo-2-n32.d +++ b/gas/testsuite/gas/mips/reginfo-2-n32.d @@ -1,4 +1,4 @@ #name: MIPS assembled .reginfo section size (n32) -#as: -n32 -mips3 +#as: -n32 -mips3 --no-pad-sections #source: reginfo-2.s #error-output: reginfo-2.l