Normalize response params

panda-madness · Apr 6, 2018 · e488b47 · e488b47
1 parent 28ac6ed
commit e488b47
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 7 deletions.
diff --git a/composer.json b/composer.json
@@ -3,7 +3,7 @@
     "description": "A PHP client for the Qazkom Epay payment gateway",
     "type": "library",
     "license": "MIT",
-    "version": "0.0.8",
+    "version": "0.0.9",
     "authors": [
         {
             "name": "Margulan Baimbet",

diff --git a/src/Responses/PaymentResponse.php b/src/Responses/PaymentResponse.php
@@ -29,7 +29,7 @@ private function parseAttributes(\SimpleXMLElement $xml) {
         $props = [];
 
         foreach ($xml->attributes() as $name => $value) {
-            $props[strtolower($name)] = $value;
+            $props[strtolower($name)] = (string)$value;
         }
 
         return $props;

diff --git a/src/Responses/StatusResponse.php b/src/Responses/StatusResponse.php
@@ -19,12 +19,17 @@ protected function parse(\SimpleXMLElement $xml)
 
         $response = $this->xml->xpath('/document/bank/response')[0];
 
-        foreach ($order->attributes() as $name => $value) {
-            $props['order'][$name] = (string)$value;
-        }
+        $props['response'] = $this->parseAttributes($response);
+        $props['order'] = $this->parseAttributes($order);
+
+        return $props;
+    }
+
+    private function parseAttributes(\SimpleXMLElement $xml) {
+        $props = [];
 
-        foreach ($response->attributes() as $name => $value) {
-            $props['response'][$name] = (string)$value;
+        foreach ($xml->attributes() as $name => $value) {
+            $props[strtolower($name)] = (string)$value;
         }
 
         return $props;