GH648 Clean up testing

Author: loicdiridollou

tests/test_timefuncs.py

@@ -16,10 +16,12 @@
     TH,
     TU,
     WE,
+    weekday as WeekdayClass,
 )
 import numpy as np
 from numpy import typing as npt
 import pandas as pd
+import pytest
 import pytz
 from typing_extensions import (
     assert_never,
@@ -1293,19 +1295,13 @@ def test_weekofmonth_init():
     )
 
 
-def test_dateoffset_weekday():
-    """Check that you can create a `pd.DateOffset` from weekday of int or dateutil.relativedelta."""
-    # check for int
+@pytest.mark.parametrize("weekday", [1, MO, TU, WE, TH, TH, FR, SA, SU])
+def test_dateoffset_weekday(weekday: int | WeekdayClass):
+    """Check that you can create a `pd.DateOffset` from weekday of int or relativedelta.weekday."""
     check(
-        assert_type(pd.offsets.DateOffset(weekday=1), pd.offsets.DateOffset),
+        assert_type(pd.offsets.DateOffset(weekday=weekday), pd.offsets.DateOffset),
         pd.offsets.DateOffset,
     )
-    # check for relativedelta
-    for weekday in [MO, TU, WE, TH, TH, FR, SA, SU]:
-        check(
-            assert_type(pd.offsets.DateOffset(weekday=weekday), pd.offsets.DateOffset),
-            pd.offsets.DateOffset,
-        )
 
 
 def test_date_range_unit():