ModuleNotFoundError running example on Binder

[TomNicholas]

I tried running the example notebook in binder linked from your blog post @rabernat , but get a ModuleNotFoundError when it tries to initialise the llcreader model object:

---------------------------------------------------------------------------
ModuleNotFoundError                       Traceback (most recent call last)
<ipython-input-2-971699e2a20f> in <module>
----> 1 model = llcreader.ECCOPortalLLC2160Model()
      2 model

/srv/conda/envs/notebook/lib/python3.6/site-packages/xmitgcm/llcreader/known_models.py in __init__(self)
     77 
     78     def __init__(self):
---> 79         fs = _make_http_filesystem()
     80         base_path = 'https://data.nas.nasa.gov/ecco/download_data.php?file=/eccodata/llc_2160/compressed'
     81         grid_path = 'https://data.nas.nasa.gov/ecco/download_data.php?file=/eccodata/llc_2160/grid'

/srv/conda/envs/notebook/lib/python3.6/site-packages/xmitgcm/llcreader/known_models.py in _make_http_filesystem()
     16 def _make_http_filesystem():
     17     import fsspec
---> 18     from fsspec.implementations.http import HTTPFileSystem
     19     return HTTPFileSystem()
     20 

/srv/conda/envs/notebook/lib/python3.6/site-packages/fsspec/implementations/http.py in <module>
      1 from __future__ import print_function, division, absolute_import
      2 
----> 3 import aiohttp
      4 import asyncio
      5 import logging

ModuleNotFoundError: No module named 'aiohttp'

[rabernat]

This is an fsspec dependency problem. I know there is a github issue for it, but I can't track it down. @martindurant will know.

This binder is using a very old image:

pangeo-ecco-llc/binder/Dockerfile

Line 1 in 8578235

FROM pangeo/pangeo-notebook-onbuild:2019.05.23

Updating it would be a good intro to the Pangeo cloud docker stack: https://github.com/pangeo-data/pangeo-docker-images/

[martindurant]

Indeed, HTTPFileSystem has been using aiohttp for quite some time now. It seems that that build is picking up a relatively recent version, but I don't see how dependencies are being installed.

Note that you can (pip) install fsspec[http] for this specific case.

Also, it would be more typical to do fsspec.filesystem("http") instead of from fsspec.implementations.http import HTTPFileSystem, so you would at least get a better error message. I don't suppose this can be changed in this repo.