Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Can this be part of the roadmap for practical use case as top priority. tls / ktls support first. #534

Closed
ouvaa opened this issue Feb 26, 2024 · 11 comments
Assignees
Labels
enhancement New feature or request proposal Proposal for this repo
Milestone

Comments

@ouvaa
Copy link

ouvaa commented Feb 26, 2024

Description of new feature

  1. gnet-ktls
  2. gnet-ktls-h2
  3. gnet-ktls-h2-iouring

once all the above is done, it's "perfect"

Scenarios for new feature

for use in real world scenario behind cloudflare as cloudflare only supports grpc with http2
https://developers.cloudflare.com/network/grpc-connections/
Enable gRPC
​​Requirements
Your gRPC endpoint must listen on port 443.
Your gRPC endpoint must support TLS and HTTP/2.
HTTP/2 must be advertised over ALPN.

possible to make this happen? thx.
please pull the ktls as currently having issues with the dependencies. also, you can pull into dev branch.

Breaking changes or not?

Yes

Code snippets (optional)

No response

Alternatives for new feature

None.

Additional context (optional)

None.

@ouvaa ouvaa added enhancement New feature or request proposal Proposal for this repo labels Feb 26, 2024
@ouvaa
Copy link
Author

ouvaa commented Feb 26, 2024

@panjf2000 will be one of your sponsor if this is part of the roadmap.
do make this gnet-ktls or gnet-ktls-h2 happen for now.

@panjf2000 panjf2000 added this to the Long term milestone Feb 29, 2024
@ouvaa
Copy link
Author

ouvaa commented Mar 28, 2024

@panjf2000 sorry i just realised i asked before.
but do put this as top priority. thx

@ouvaa ouvaa changed the title [Feature]: Can this be part of the roadmap for practical use case. [Feature]: Can this be part of the roadmap for practical use case as top priority. tls / ktls support first. Mar 28, 2024
@panjf2000
Copy link
Owner

Implementing TLS for gnet is not a trivial job and I'm not sure that I have much time in the near future. Therefore I can't guarantee an ETA on this. If you're in a hurry, you may want to seek out other off-the-shelf solutions.

@ouvaa
Copy link
Author

ouvaa commented Mar 28, 2024

@panjf2000 yes i understand but can you also try out gnet ktls?
it's almost done and the issue i've mentioned here:
0-haha/gnet_tls_examples#2

do u think u can just have a quick patch on it? it's working except some connection stack overflow issue

@ouvaa
Copy link
Author

ouvaa commented Mar 28, 2024

@panjf2000 possible to do something along this line so we can at least have a wrapper around the listener part?
i've checked gnet code and cant seem to find something similar

valyala/fasthttp#431

@ouvaa
Copy link
Author

ouvaa commented Mar 28, 2024

@panjf2000 this repo support tls too but it's using an older version of gnet.
pls look into it

https://github.com/luyu6056/tls
https://github.com/luyu6056/bbs
https://github.com/luyu6056/gnet

@ouvaa
Copy link
Author

ouvaa commented Mar 28, 2024

@panjf2000 i finished testing https://github.com/luyu6056/socks5

the http2 is amazing and it works. please incorporate into gnet examples etc

the tls works without http too.

please look into it. it may have some edge case

@panjf2000
Copy link
Owner

I'll see what I can do, but still, no specific guarantees for that.

@ouvaa
Copy link
Author

ouvaa commented Mar 29, 2024

@panjf2000 u can really look at the https://github.com/luyu6056/tls etc repos mentioned or just use a wrapper around the listener part like fasthttp. the luyu6056 i've tested is working well but it's not multicore enabled or difficult to set.

i'll sponsor and help you get more sponsors once this is done. really need tls rather urgently. hope to see it done within 3 weeks. it's been too long and with luyu6056 done, and wrapper example shown, this shld be gnet's top priority. it's 2024 and without tls it's just not practical for business use.

thx in advance

@sprappcom
Copy link

@panjf2000 with reference to this. pls make this happen. it's really too long.
#608

thx in advance.

@panjf2000
Copy link
Owner

Move to #16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request proposal Proposal for this repo
Projects
None yet
Development

No branches or pull requests

3 participants