Release 1.3.5 (#246)

* Update images for lint and test-behat jobs

* Bump yoast/phpunit-polyfills from 1.0.3 to 1.0.4

* Bump dealerdirect/phpcodesniffer-composer-installer from 0.7.2 to 1.0.0 (#229)

Bumps [dealerdirect/phpcodesniffer-composer-installer](https://github.com/Dealerdirect/phpcodesniffer-composer-installer) from 0.7.2 to 1.0.0.
- [Release notes](https://github.com/Dealerdirect/phpcodesniffer-composer-installer/releases)
- [Changelog](https://github.com/PHPCSStandards/composer-installer/blob/main/.github_changelog_generator)
- [Commits](PHPCSStandards/composer-installer@v0.7.2...v1.0.0)

---
updated-dependencies:
- dependency-name: dealerdirect/phpcodesniffer-composer-installer
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* [CMSP-79] PHP 8.2 (#232)

* Bump grunt from 1.5.3 to 1.6.1 (#235)

* fix GPL license version (#236)

* Add CMS Platform to CODEOWNERS (#239)

* [BUGS-5809] Add fallback for $session->get_data() (#237)

* fix GPL license version

* add a fallback
if $session is not null but the ->get_data is this creates a PHP warning
It's possible this might escallate to a fatal in PHP 8+
Originally reported in https://wordpress.org/support/topic/php-warning-session_start-failed-to-read-session-data-user/

* exclude short ternaries being disallowed
I fundamentally disagree with the guidance that they are "rarely used
correctly"

* bump version

* update/add changelog

* Remove gruntfile and package.json (#243)

The only thing this was being used for was a readme to markdown script that we're not using.

* Update the "necessary assets" step (#242)

* Update the "necessary assets" step

Replace "Confirm that the necessary assets are present in the newly created tag, and test on a WP install if desired" with the actual step for this repository.

* call out .gitattributes, specifically

Co-authored-by: John Spellman <[email protected]>

* remove extra number list item

---------

Co-authored-by: John Spellman <[email protected]>

* Bump yoast/phpunit-polyfills from 1.0.4 to 1.0.5 (#245)

Bumps [yoast/phpunit-polyfills](https://github.com/Yoast/PHPUnit-Polyfills) from 1.0.4 to 1.0.5.
- [Release notes](https://github.com/Yoast/PHPUnit-Polyfills/releases)
- [Changelog](https://github.com/Yoast/PHPUnit-Polyfills/blob/2.x/CHANGELOG.md)
- [Commits](Yoast/PHPUnit-Polyfills@1.0.4...1.0.5)

---
updated-dependencies:
- dependency-name: yoast/phpunit-polyfills
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* bump version & update changelog

* add john to contributors

* explicitly define which symfony/yaml to use

* update composer so it pulls the right symfony/yaml

* we actually shouldn't need to define symfony/yaml
if we do a composer update before install for 7.4 tests

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: John Spellman <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Author: 3 people

.circleci/config.yml

@@ -94,7 +94,7 @@ jobs:
       - restore_cache:
           keys:
             - test-phpunit-74-dependencies-{{ checksum "composer.json" }}
-      - run: composer install -n --prefer-dist
+      - run: composer update && composer install -n --prefer-dist
       - save_cache:
           key: test-phpunit-74-dependencies-{{ checksum "composer.json" }}
           paths:

CONTRIBUTING.md

@@ -31,7 +31,7 @@ The `develop` branch is the development branch which means it contains the next
 1. Create a PR against the `main` branch.
 1. After all tests pass and you have received approval from a CODEOWNER (including resolving any merge conflicts), merge the PR into `main`.
 1. Pull `main` locally, create a new tag, and push up.
-1. Confirm that the necessary assets are present in the newly created tag, and test on a WP install if desired.
+1. (Optional) Download the zipped asset from the release and unzip locally, confirming that the expected files are present (and unexpected files, e.g. files outlined in [.gitattributes](https://github.com/pantheon-systems/wp-native-php-sessions/blob/main/.gitattributes) are omitted).
 1. Create a [new release](https://github.com/pantheon-systems/wp-native-php-sessions/releases/new) using the tag created in the previous steps, naming the release with the new version number, and targeting the tag created in the previous step. Paste the release changelog from `CHANGELOG.md` into the body of the release and include a link to the closed issues if applicable.
 1. Wait for the [_Release wp-native-php-sessions plugin to wp.org_ action](https://github.com/pantheon-systems/wp-native-php-sessions/actions/workflows/wordpress-plugin-deploy.yml) to finish deploying to the WordPress.org repository. If all goes well, users with SVN commit access for that plugin will receive an emailed diff of changes.
-1. Check WordPress.org: Ensure that the changes are live on https://wordpress.org/plugins/wp-native-php-sessions/. This may take a few minutes.
+1. Check WordPress.org: Ensure that the changes are live on https://wordpress.org/plugins/wp-native-php-sessions/. This may take a few minutes.

Gruntfile.js

@@ -1,9 +1,9 @@
 # WordPress Native PHP Sessions #
-**Contributors:** [getpantheon](https://profiles.wordpress.org/getpantheon), [outlandish josh](https://profiles.wordpress.org/outlandish-josh), [mpvanwinkle77](https://profiles.wordpress.org/mpvanwinkle77), [danielbachhuber](https://profiles.wordpress.org/danielbachhuber), [andrew.taylor](https://profiles.wordpress.org/andrew.taylor), [jazzs3quence](https://profiles.wordpress.org/jazzs3quence), [stovak](https://profiles.wordpress.org/stovak)  
+**Contributors:** [getpantheon](https://profiles.wordpress.org/getpantheon), [outlandish josh](https://profiles.wordpress.org/outlandish-josh), [mpvanwinkle77](https://profiles.wordpress.org/mpvanwinkle77), [danielbachhuber](https://profiles.wordpress.org/danielbachhuber), [andrew.taylor](https://profiles.wordpress.org/andrew.taylor), [jazzs3quence](https://profiles.wordpress.org/jazzs3quence), [stovak](https://profiles.wordpress.org/stovak), [jspellman](https://profiles.wordpress.org/jspellman/)  
 **Tags:** comments, sessions  
 **Requires at least:** 4.7  
-**Tested up to:** 6.1  
-**Stable tag:** 1.3.4  
+**Tested up to:** 6.2  
+**Stable tag:** 1.3.5  
 **Requires PHP:** 5.4  
 **License:** GPLv2 or later  
 **License URI:** http://www.gnu.org/licenses/gpl-2.0.html  
@@ -71,6 +71,10 @@ This mu-plugin will load WP Native PHP Sessions before all other plugins, while
 
 ## Changelog ##
 
+### 1.3.5 (April 7, 2023) ###
+* Bump yoast/phpunit-polyfills from 1.0.4 to 1.0.5 [[#245](https://github.com/pantheon-systems/wp-native-php-sessions/pull/245)].
+* Bump tested up to version
+
 ### 1.3.4 (February 7, 2023) ###
 * Add fallback for $session->get_data() [[#237(https://github.com/pantheon-systems/wp-native-php-sessions/pull/237)]] (reported [on WordPress.org](https://wordpress.org/support/topic/php-warning-session_start-failed-to-read-session-data-user/))
 * Update CODEOWNERS file [[#239](https://github.com/pantheon-systems/wp-native-php-sessions/pull/239)]