Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:title-abbreviations problem #55

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

fatteme
Copy link

@fatteme fatteme commented Dec 17, 2020

Related issue

#50 Title Abbreviations

Description

Add another input in titleCase function named preserveUpperCase

Check List

  • All test passed
  • Added test to ensure correctness

@codecov-io
Copy link

Codecov Report

Merging #55 (5b35868) into master (d3183a8) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #55   +/-   ##
=======================================
  Coverage   98.84%   98.84%           
=======================================
  Files         108      108           
  Lines         955      956    +1     
  Branches      216      216           
=======================================
+ Hits          944      945    +1     
  Misses          9        9           
  Partials        2        2           
Impacted Files Coverage Δ
src/case/title_case.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3183a8...5b35868. Read the comment docs.

Copy link
Owner

@panzerdp panzerdp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's one small thing to fix.

src/case/title_case.js Outdated Show resolved Hide resolved
@damusix
Copy link

damusix commented Mar 19, 2021

Bump. We need this fix.

@fatteme fatteme requested a review from panzerdp July 15, 2022 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants