Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why are you using 'crossinline' modifier in body param of NormalOpenApiRoute.route method #61

Open
y9san9 opened this issue Jul 1, 2020 · 4 comments

Comments

@y9san9
Copy link

y9san9 commented Jul 1, 2020

I am making DSL for your framework and when I'm trying to make wrapper function the method and getting an internal JVM exception cause of invalid bytecode generation
image
I haven't found the real solution, but in my case changing 'crossinline' modifier to 'noinline' helped, can you ask, why are you using the first one ?
or may be even can you replace crossinline into noinine ?

@Wicpar
Copy link
Collaborator

Wicpar commented Jul 1, 2020

Crossinline is necessary to preserve reification, but maybe it is not necessary in most cases.
Can you show me how you are calling the function ?

@y9san9
Copy link
Author

y9san9 commented Jul 1, 2020

@Wicpar Im not calling the function, it is compile error, but Idk why it shows only in compile log, not in ide

@Wicpar
Copy link
Collaborator

Wicpar commented Jul 1, 2020

Ah it could be a jdk version mismatch.

@y9san9
Copy link
Author

y9san9 commented Jul 1, 2020

@Wicpar I found that is JVM bug, but if crossinline is necessary in your case then ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants