Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Surface BL 12 and 13 urls #119

Open
jcowey opened this issue Dec 7, 2021 · 6 comments
Open

Surface BL 12 and 13 urls #119

jcowey opened this issue Dec 7, 2021 · 6 comments
Assignees

Comments

@jcowey
Copy link
Member

jcowey commented Dec 7, 2021

https://papyri.info/ddbdp/p.iand;3;40

URL / URI in hgv file

@jcowey
Copy link
Member Author

jcowey commented Jan 9, 2023

Change the target from

https://aquila.zaw.uni-heidelberg.de/bl/hgv/35303

to

https://beehive.zaw.uni-heidelberg.de/hgv/35303

Decide what we want the HTML to declare on the basis of https://github.com/papyri/idp.data/blob/master/HGV_meta_EpiDoc/HGV36/35303.xml#L96-L98

<bibl type="BL-online">
   <ptr target="https://aquila.zaw.uni-heidelberg.de/bl/hgv/35303"/>
</bibl>

Then tweak the XSLT and everything should just work already.

@jcowey
Copy link
Member Author

jcowey commented Jan 16, 2023

Testing on https://papyri.info/ddbdp/p.eleph;;1intdupl with papyri/idp.data@eb3890a

Changed https://github.com/papyri/idp.data/blob/master/HGV_meta_EpiDoc/HGV6/5836.xml#L93 to

<ptr target="https://beehive.zaw.uni-heidelberg.de/hgv/5836">BL Online</ptr>

Got the following error: https://github.com/papyri/idp.data/actions/runs/3931389405/jobs/6722574840

because ptr must remain an empty element: https://tei-c.org/release/doc/tei-p5-doc/en/html/ref-ptr.html

So I reverted with papyri/idp.data@446cabb

So that the “Actions“ are clean: https://github.com/papyri/idp.data/actions/runs/3931499319

@jcowey
Copy link
Member Author

jcowey commented Jan 16, 2023

How should this be encoded so that the link will appear?

@jcowey jcowey changed the title Surface BL 13 urls Surface BL 12 and 13 urls Jan 16, 2023
@jcowey
Copy link
Member Author

jcowey commented Jan 16, 2023

Tried again with

<biblScope ref="https://beehive.zaw.uni-heidelberg.de/hgv/5836">Berichtigungsliste online</biblScope>

ref not allowed on biblScope

@hcayless
Copy link
Member

hcayless commented Sep 4, 2024

Would

<ref target="https://beehive.zaw.uni-heidelberg.de/hgv/5836">Berichtigungsliste online</ref>

work? That seems cleaner. It would mean adjusting @samosafuz's fix.

@samosafuz
Copy link
Member

TBH, I prefer the current structure in @jcowey's test file P.Iand 3 40, where we find bibl elements distinguished by @type, with parent listBibl. If we wanted to use ref, it would take the place of the ptr element, but I don't think that's any more elegant – the empty ptr element is sufficient, IMO, since it's the link in @target that we need.

To its credit, the current structure is modeled on the way that div[@type='bibliography'][@subtype='illustrations'] is structured in DCLP, where descendant::bibl/@type can have the values printed or online. I was working with this structure in mind when I proposed the fix, but it can be changed depending on what we decide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants