Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Highlighting regex issues in recent Java versions #155

Open
hcayless opened this issue Jul 14, 2023 · 0 comments
Open

Highlighting regex issues in recent Java versions #155

hcayless opened this issue Jul 14, 2023 · 0 comments

Comments

@hcayless
Copy link
Member

hcayless commented Jul 14, 2023 •
edited
Loading

Some time between Java 11 and 19, the regular expressions we generate to handle search result highlighting start returning no hits. Note that the regex compiles but fails to match anything.

Failing tests are (under openjdk version "20.0.1" 2023-04-18):

info.papyri.dispatch.FileUtilsTest.testFindMatchesElision
info.papyri.dispatch.FileUtilsTest.testFindMatchesNot
info.papyri.dispatch.FileUtilsTest.testFindMatchesMultipleTerms
info.papyri.dispatch.FileUtilsTest.testFindMatchesIdiwLogw
info.papyri.dispatch.FileUtilsTest.testFindMatchesSubstringPhrase
info.papyri.dispatch.FileUtilsTest.testNgramHighlightLineNo

All tests pass under openjdk version "11.0.19" 2023-04-18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hcayless