Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade or remove jQuery #84

Open
hcayless opened this issue Oct 7, 2020 · 1 comment
Open

Upgrade or remove jQuery #84

hcayless opened this issue Oct 7, 2020 · 1 comment
Assignees

Comments

@hcayless
Copy link
Member

hcayless commented Oct 7, 2020

We're still using an old version of jQuery, and it's causing warnings.

@hcayless hcayless self-assigned this Oct 7, 2020
@ryanfb
Copy link
Member

ryanfb commented Oct 7, 2020

Note that PE SoSOL also currently uses jQuery loaded from PN in order to resource-share: https://github.com/sosol/sosol/blob/master/app/views/layouts/pn.html.erb#L21

If we pull it from use in PN, the file probably needs to still be there for use by PE until we deploy a version of PE that hosts its own (upgraded) version. See also this issue for moving PE to the Rails asset pipeline (it looks like I did some experimental work on a branch there to move things over to the asset pipeline which required self-hosting an upgraded jQuery): sosol/sosol#97

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants