-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improvement ideas / missing features #114
Comments
For number 1 I disagree because I think if you need async requests you can I agree on number 2 that something else then an md5 passed to the cache I also like the idea of different ttls. Pull requests are always welcome ;) On Wed, Apr 6, 2016, 6:07 PM Inve1951 [email protected] wrote:
|
This could be easily handled with an implementation of The other two points haven't been a big deal for me up until now, since i can just clear the cache and my project is still in an early state where a database isn't needed. Those points however will arise again for me and in case nobody implemented those by then i might do it. Btw limits are unique per api-key. Atm to be able to run multiple projects/api-keys on the same server without sacrificing your rate limits, you'd have to e.g. prefix the md5-key in a custom |
Yes you are right. It goes even further. Limits are also unique per region so if riot gives you like 3000 req/10 seconds you can do 3k to euw and another 3k to NA in that time interval. Its correct that the current implementation doesnt take this into account. Maybe you should open another issue with that to track it seperatly. If you find yourself into patching |
The region is taken into account already: |
I also dont want to do changes like that until @paquettg reports back because this will be a breaking change for custom Cache implementations and therefor It would be nice to bump the composer version number before doing this. This way everyone on dev-master that dont want to adopt that change immediatly can switch to packegist version 0.6.4. |
the api is nice and good as is but i'm missing some features:
this will reduce page loading times a lot
(e.g. request MatchDto's for a bunch of matches)
(guzzle supports async requests via Promises)
this will allow for easy hook-up of databases
(could be done by passing an associative array)
there's no way you can pull info from a database with just the md5 key
error caching makes sense to me, but why remember those for the same duration as you do with Dto's?
e.g. when riot gives a 503 error on a reliable request it makes no sense to cache it for much longer than a minute
The text was updated successfully, but these errors were encountered: