Skip to content

Commit 23ec2df

Browse files
committed
rm remaining plots in scores
1 parent cbb8a2f commit 23ec2df

File tree

2 files changed

+5
-8
lines changed

2 files changed

+5
-8
lines changed

rampwf/score_types/generative_regression.py

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -166,13 +166,12 @@ class MDLikelihoodRatio(BaseScoreType):
166166

167167
def __init__(self, name='lr', precision=2,
168168
min_likelihood=1.4867195147342979e-06, # 5 sigma
169-
output_dim=None, verbose=False, plot=False, multivar=False):
169+
output_dim=None, verbose=False, multivar=False):
170170
self.name = name
171171
self.precision = precision
172172
self.output_dim = output_dim
173173
self.min_likelihood = min_likelihood
174174
self.verbose = verbose
175-
self.plot = plot
176175
self.multivar = multivar
177176

178177
def __call__(self, y_true, y_pred):
@@ -181,8 +180,8 @@ def __call__(self, y_true, y_pred):
181180
multivar=self.multivar,
182181
min_likelihood=self.min_likelihood,
183182
output_dim=self.output_dim,
184-
verbose=self.verbose or self.plot)
185-
if self.verbose or self.plot:
183+
verbose=self.verbose)
184+
if self.verbose:
186185
nll_reg, log_lks = nll_reg_score(y_true, y_pred)
187186
else:
188187
nll_reg = nll_reg_score(y_true, y_pred)
@@ -291,13 +290,11 @@ class MDKSCalibration(BaseScoreType):
291290
minimum = 0.0
292291
maximum = 1.0
293292

294-
def __init__(self, name='ks', precision=2, output_dim=None, verbose=False,
295-
plot=False):
293+
def __init__(self, name='ks', precision=2, output_dim=None, verbose=False):
296294
self.name = name
297295
self.precision = precision
298296
self.output_dim = output_dim
299297
self.verbose = verbose
300-
self.plot = plot
301298

302299
def __call__(self, y_true, y_pred):
303300
n_instances = len(y_true)

rampwf/tests/kits/acrobot_ts_generative_regression/problem.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
rw.score_types.MDLikelihoodRatio('lr', precision=2),
2424
rw.score_types.MDOutlierRate('or', precision=4),
2525
rw.score_types.MDR2('r2', precision=6),
26-
rw.score_types.MDKSCalibration('ks', precision=4, plot=False),
26+
rw.score_types.MDKSCalibration('ks', precision=4),
2727
]
2828
# generate scores for each output dimension
2929
_score_types = copy.deepcopy(score_types)

0 commit comments

Comments
 (0)