Merge pull request #43 from ethcore/fix-jsonrpc-omitted

Don't serialize version field if it is not set explicitly

Author: NikVolf

core/src/io.rs

@@ -287,7 +287,7 @@ fn write_response(response: Response) -> String {
 mod tests {
 	use futures::{self, Future};
 	use types::{Value};
-	use super::{IoHandler};
+	use super::{IoHandler, Compatibility};
 
 	#[test]
 	fn test_io_handler() {
@@ -303,6 +303,20 @@ mod tests {
 		assert_eq!(io.handle_request_sync(request), Some(response.to_string()));
 	}
 
+	#[test]
+	fn test_io_handler_1dot0() {
+		let mut io = IoHandler::with_compatibility(Compatibility::Both);
+
+		io.add_method("say_hello", |_| {
+			Ok(Value::String("hello".to_string()))
+		});
+
+		let request = r#"{"method": "say_hello", "params": [42, 23], "id": 1}"#;
+		let response = r#"{"result":"hello","id":1}"#;
+
+		assert_eq!(io.handle_request_sync(request), Some(response.to_string()));
+	}
+
 	#[test]
 	fn test_async_io_handler() {
 		let mut io = IoHandler::new();

core/src/types/response.rs

@@ -8,6 +8,7 @@ use super::{Id, Value, Error, ErrorCode, Version};
 #[derive(Debug, PartialEq, Serialize, Deserialize)]
 pub struct Success {
 	/// Protocol version
+    #[serde(skip_serializing_if = "Option::is_none")]	
 	pub jsonrpc: Option<Version>,
 	/// Result
 	pub result: Value,